1579458 - Setting keyword.enabled to false should remove the URL bar placeholder (or the search with part of it)

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P3)

Description

[Mike Kaply [:mkaply]]

The preference keyword.enabled allows you to turn off searching in the URL bar so it is just used for URLs (helpful in environments that aren't connected to the general internet).

When you do this, our place holder still says "Search with Google or enter address"

It shouldn't have Google in there.

Comment 1

[Marco Bonardo [:mak]]

well, you can still search using one-off buttons or search suggestions...

Comment 2

[Mike Kaply [:mkaply]]

There are preferences to remove all of those as well :)

browser.urlbar.oneOffSearches
browser.search.suggest.enabled

_setURLBarPlaceholder can just be made to take the default if keyword.enabled is false. (It will still say search, but at least it won't be Google)

Comment 3

[Marco Bonardo [:mak]]

Because keyword.enabled is not exposed in preferences, I don't think this is critical. sure if we expose that pref through policies, then I can see it's an enterprise bug. I'd take a patch for it.

Comment 7

[Moritz Beier [:mbeier]]

Attachment: Bug 1579458 - Setting keyword.enabled to false should change the URL bar placeholder. r?#urlbar-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/89966d664a00
https://hg.mozilla.org/integration/autoland/rev/d0b56c0d07dd
Setting keyword.enabled to false should change the URL bar placeholder. r=urlbar-reviewers,fluent-reviewers,bolsson,Standard8

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d0b56c0d07dd