Remove XUL grid from browser/components/preferences/languages.xul
Categories
(Firefox :: Settings UI, task, P1)
Tracking
()
People
(Reporter: ntim, Assigned: ntim)
References
Details
Attachments
(1 file, 1 obsolete file)
We could use CSS grid here with some tweaks on the platform side.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Comment 2•5 years ago
|
||
As discussed, it might be useful to turn off blockification of -moz-box (at least for grid items).
Here's a patch that makes -moz-box blockify to itself. Tested locally with this testcase:
<!DOCTYPE html>
<i>
NOTE: Remember to toggle layout.css.xul-box-display-values.content.enabled
before running this test.
</i>
<br>
<br>
<div style="display: grid">
<div id="item" style="display: -moz-box">
grid item
</div>
<div>
<div id="grandchild" style="display: -moz-box">
grid grandchild (child of grid item)
</div>
</div>
</div>
<br><br>
<div id="report">
</div>
<script>
report.textContent =
"Display value for -moz-box grid item: [" +
getComputedStyle(item).display +
"], vs. for grandchild: [" +
getComputedStyle(grandchild).display + "]";
</script>
|
|
||
Updated•5 years ago
|
|
|
||
Comment 3•5 years ago
|
||
(I think that "don't-blockify -moz-box" patch might break the toolbar when the awesomebar dropdown is open, and possibly breaks other parts of the UI. Hypothetically if we wanted to take that patch and avoid these issues, we could probably sprinkle around some explicit display:block stylings on elements where we've unknowingly been depending on some piece of -moz-box auto-blockification that this patch prevents from happening.)
|
||
Updated•5 years ago
|
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/aefedc124f9a Remove XUL grid from browser/components/preferences/languages.xul. r=jaws
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
|
|
||
Updated•5 years ago
|
|
||
Comment 6•5 years ago
|
||
Backed out as per Gijs req for causing a regression in Bug 1593060
Backout link: https://hg.mozilla.org/releases/mozilla-beta/rev/dc8f31580f29bf0be039faa8f2a70a985c0333bc
|
||
Comment 7•5 years ago
|
||
This only got backed out of beta, so re-resolving and fixing release flags.
|
||
Comment 8•4 years ago
•
|
||
Backed out on Daniel's request: https://hg.mozilla.org/releases/mozilla-beta/rev/4c8e9ab10099120bec930b6dcde69428b2c18be0
Description
•