1579575 - Account Central not appearing after a new account is created (TB 70 beta)

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[WaltS48 [:walts48]]

Attachment: no-account-central.png

Installed TB 70.0b1 en-GB on Windows 10 and Ubuntu 18.04.3 LTS Linux.
Started each from a terminal command to launch the profile manager
Created tests profiles.
Started TB 70.0b1 with the test profile.
Noticed there was a new Account Wizard.
Created my POP3 account.
Email downloaded to the Inbox.
Selected the Account in the Folder pane.

The Account Central pane was still showing "Set up an account" and "Create a new calendar".
I had the same result after creating my IMAP account.

I should have seen the full Account Central Pane with the "Email", "Accounts" and "Advanced Features" sections.
Those did appear after restart of TB 70.0b1 on each system.

Comment 1

[WaltS48 [:walts48]]

Eckard did you see this when doing Mac testing?

Comment 2

[WaltS48 [:walts48]]

Do you think fixing this bug will fix the Newsgroups heading and the Feeds heading also not appearing in Account Central after creating those types of accounts?

I had to select the account in the Folder pane, right click and use Subscribe from the context menu.

It appears that everything works after an update from TB 69.0b4 to 70.0b1.

Comment 3

[Jorg K (CEST = GMT+2)]

OK, so the issue is that Account Central shows, but it has the wrong content, yes?

Actual:
The Account Central pane was still showing "Set up an account" and "Create a new calendar".

Expected:
I should have seen the full Account Central Pane with the "Email", "Accounts" and "Advanced Features" sections.

Personally, to me this is not a blocker. Looks like a regression from bug 1551133. We'll see what Alex and Magnus say.

Comment 4

[Eckard Berberich]

(In reply to WaltS48 [:walts48] from comment #1)

Eckard did you see this when doing Mac testing?

I just tested the account creation again in a new profile and, yes, I can confirm this issue.

Comment 5

[WaltS48 [:walts48]]

(In reply to Jorg K (GMT+2) from comment #3)

OK, so the issue is that Account Central shows, but it has the wrong content, yes?

Yes

Personally, to me this is not a blocker. Looks like a regression from bug 1551133. We'll see what Alex and Magnus say.

I thought it might have something to do with the new account creation dialog.

Comment 6

[:aceman]

I'm not sure this has anything to do with bug 1551133.
I can reproduce this without creating a new account, just by visiting the Account central for any account and then choosing other folders/accounts, when the Account central is displayed it is always for the same account that was viewed the first time.
I debugged it and the page is never reloaded to pick up the new selected account.

Comment 7

[:aceman]

This is actually from bug 1568440, which does exactly that, prevents the page from refreshing...
Reverting that change fixes this problem. But of course it reopens bug 1568440 so a common solution needs to be found.

Comment 8

[:aceman]

Attachment: 1579575.patch

We probably need to check if the selected folder changed. If so, we have to reload the page. So let's make the href contain the folder URI too.

Comment 9

[:aceman]

Please also check if bug 1568440 is covered by this.

Comment 10

[:aceman]

Attachment: 1579575.patch v1.1

Now passing eslint/prettier :)

Comment 11

[Jorg K (CEST = GMT+2)]

Comment on attachment 9091311 [details] [diff] [review]
1579575.patch v1.1

Sorry, I'm really incompetent here.

Comment 12

[Geoff Lankow (:darktrojan)]

Comment on attachment 9091311 [details] [diff] [review]
1579575.patch v1.1

I wonder if it would be better to use the account key instead of the URI, but it scarcely matters.

Comment 13

[Jorg K (CEST = GMT+2)]

On a closer look, the change makes sense to me, but let's go with r=darktrojan.

Comment 14

[:aceman]

The argument after ? is actually unused now, in this patch it is just to differentiate the 'spec' for different accounts.
But I already have a followup prepared that uses the argument and simplifies the account central code.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6928adb14504
reload Account Central pane if the selected folder changed. r=darktrojan

Comment 16

[Jorg K (CEST = GMT+2)]

TB 70 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/d78d701cf85a1074973f50be1c27c1fa3c029a8c