Closed Bug 1579652 Opened Last month Closed Last month

package odnoklassniki.js chat protocol in an official Thunderbird package?

Categories

(Thunderbird :: Instant Messaging, defect)

defect
Not set

Tracking

(thunderbird_esr6869+ fixed, thunderbird70 fixed, thunderbird71 fixed)

RESOLVED FIXED
Thunderbird 71.0
Tracking Status
thunderbird_esr68 69+ fixed
thunderbird70 --- fixed
thunderbird71 --- fixed

People

(Reporter: aceman, Assigned: clokep)

Details

Attachments

(1 file)

As discovered in bug 1427590 comment 22, comparing objdir/dist/bin/components (in a local build) with the omni.ja/components folder (in a packaged TB distribution), there is also odnoklassniki.js file missing in omni.ja. All other chat protocols seem to be packaged except this one.

Flags: needinfo?(clokep)

As far as I can tell this is not done on purpose. Looking (briefly) at the moz.build files though I don't see why this would be the case. I'll try to look into it further soon.

It seems moz.build isn't the authoritative source on what gets packaged, we also got hit by it with other file in c-c.
The odnoklassniki file is omitted here: https://searchfox.org/comm-central/source/mail/installer/package-manifest.in#258

I tried this on Mac and didn't get any errors during packaging.

Assignee: nobody → clokep
Status: NEW → ASSIGNED
Flags: needinfo?(clokep)
Attachment #9092418 - Flags: review?(acelists)
Comment on attachment 9092418 [details] [diff] [review]
Package the JS & manifest files

Review of attachment 9092418 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this works. I have even tested that after this the Odnoklassniki account type is offered in the Account manager when creating a new chat account. Creating such an account works, but I haven't tested more functionality (I'm not registered on that network).
Attachment #9092418 - Flags: review?(acelists) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/33a02ccf84b3
Package the Odnoklassniki protocol. r=aceman

Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Comment on attachment 9092418 [details] [diff] [review]
Package the JS & manifest files

I guess you want that backported or else it won't work in 68 and 70, right?
Attachment #9092418 - Flags: approval-comm-esr68+
Attachment #9092418 - Flags: approval-comm-beta+
Target Milestone: --- → Thunderbird 71.0

(In reply to Jorg K (GMT+2) from comment #6)

Comment on attachment 9092418 [details] [diff] [review]
Package the JS & manifest files

I guess you want that backported or else it won't work in 68 and 70, right?

I don't see any reason not to backport it. Thank you!

You need to log in before you can comment on or make changes to this bug.