1579652 - package odnoklassniki.js chat protocol in an official Thunderbird package?

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[:aceman]

As discovered in bug 1427590 comment 22, comparing objdir/dist/bin/components (in a local build) with the omni.ja/components folder (in a packaged TB distribution), there is also odnoklassniki.js file missing in omni.ja. All other chat protocols seem to be packaged except this one.

Comment 1

[Patrick Cloke [:clokep]]

As far as I can tell this is not done on purpose. Looking (briefly) at the moz.build files though I don't see why this would be the case. I'll try to look into it further soon.

Comment 2

[:aceman]

It seems moz.build isn't the authoritative source on what gets packaged, we also got hit by it with other file in c-c.
The odnoklassniki file is omitted here: https://searchfox.org/comm-central/source/mail/installer/package-manifest.in#258

Comment 3

[Patrick Cloke [:clokep]]

Attachment: Package the JS & manifest files

I tried this on Mac and didn't get any errors during packaging.

Comment 4

[:aceman]

Comment on attachment 9092418 [details] [diff] [review]
Package the JS & manifest files

Review of attachment 9092418 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this works. I have even tested that after this the Odnoklassniki account type is offered in the Account manager when creating a new chat account. Creating such an account works, but I haven't tested more functionality (I'm not registered on that network).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/33a02ccf84b3
Package the Odnoklassniki protocol. r=aceman

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9092418 [details] [diff] [review]
Package the JS & manifest files

I guess you want that backported or else it won't work in 68 and 70, right?

Comment 7

[Patrick Cloke [:clokep]]

(In reply to Jorg K (GMT+2) from comment #6)

Comment on attachment 9092418 [details] [diff] [review]
Package the JS & manifest files

I guess you want that backported or else it won't work in 68 and 70, right?

I don't see any reason not to backport it. Thank you!

Comment 8

[Jorg K (CEST = GMT+2)]

TB 70 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/ed03e668db0f427b311066b418d52269b76ce41a

Comment 9

[Jorg K (CEST = GMT+2)]

TB 68.1.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/dd81c7b0d91dfb9dc60f19371f16450e5296d156