package odnoklassniki.js chat protocol in an official Thunderbird package?
Categories
(Thunderbird :: Instant Messaging, defect)
Tracking
(thunderbird_esr6869+ fixed, thunderbird70 fixed, thunderbird71 fixed)
People
(Reporter: aceman, Assigned: clokep)
Details
Attachments
(1 file)
1.69 KB,
patch
|
aceman
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr68+
|
Details | Diff | Splinter Review |
As discovered in bug 1427590 comment 22, comparing objdir/dist/bin/components (in a local build) with the omni.ja/components folder (in a packaged TB distribution), there is also odnoklassniki.js file missing in omni.ja. All other chat protocols seem to be packaged except this one.
Assignee | ||
Comment 1•5 years ago
|
||
As far as I can tell this is not done on purpose. Looking (briefly) at the moz.build files though I don't see why this would be the case. I'll try to look into it further soon.
It seems moz.build isn't the authoritative source on what gets packaged, we also got hit by it with other file in c-c.
The odnoklassniki file is omitted here: https://searchfox.org/comm-central/source/mail/installer/package-manifest.in#258
Assignee | ||
Comment 3•5 years ago
|
||
I tried this on Mac and didn't get any errors during packaging.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/33a02ccf84b3
Package the Odnoklassniki protocol. r=aceman
Comment 6•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 7•5 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #6)
Comment on attachment 9092418 [details] [diff] [review]
Package the JS & manifest filesI guess you want that backported or else it won't work in 68 and 70, right?
I don't see any reason not to backport it. Thank you!
Comment 8•5 years ago
|
||
TB 70 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/ed03e668db0f427b311066b418d52269b76ce41a
Comment 9•5 years ago
|
||
TB 68.1.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/dd81c7b0d91dfb9dc60f19371f16450e5296d156
Description
•