1579732 - When resizing browser window, Resizing window is slow

Status: RESOLVED WONTFIX

(Core :: Graphics, defect, P3)

Description

[Alice0775 White]

Attachment: about:support

This problem is more noticeable in Nightly710.a1.

Reproducible: always

Steps To Reproduce:

1. Open any web page
   e.g, http://ftp.mozilla.org/pub/firefox/nightly/2018/12/
2. Resize browser window by dragging a window side border

Actual Results:
Redraw contents is slow
Black/White area appears temporarily

Expected Results:
Firefox70.0b4 is much smoother than Nightly71.0a1

Comment 1

[Alice0775 White]

Attachment: Screencast

Comment 2

[Alice0775 White]

This is nightly only. And early beta and release seems to be not affected.

Comment 3

[Liviu Seplecan]

Hi @Alice0775 White, tested with nightly 71.0a1 & beta 70.0b5=> cannot reproduce. I've tried on both ways, with:

1. Graphics Features Compositing: Direct3D 11 (Advanced Layers)
2. Graphics Features Compositing: Webrender

• at about:config -> type "gfx.webrender.force-disabled"-> in my case in set to "false" by default so, I have Webrender on; if is set to "false" I have Direct3D 11 (Advanced Layers) enabled.
  Do you have the possibility to activate Webrender as I said above, and re-test if you get the same result ? I've noticed that you have a GPU- AMD Radeon HD 6450/ I use NVIDIA GeForce GT 1030.
  Further, I will set a component if isn't the right one please fell free to change it, also someone from dev's team could give us a hand with that.
  Regards,
  Liviu

Comment 4

[Alice0775 White]

I can also reproduce the issue with WebRender enabled.

Comment 5

[Miko Mynttinen]

(In reply to Alice0775 White from comment #4)

I can also reproduce the issue with WebRender enabled.

Hi @Alice0775 White! You said that Firefox 70.0b4 was better, would you have a regression range for this?

I did not manage to reproduce this on Windows 10 (NVIDIA) or Mac (AMD).

Comment 6

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=34a413cfb0d225c4a2007b4d37bb63087d5a1436&tochange=e96752781d2d3961d797cec48c5357c4ec293a23

Comment 7

[Alice0775 White]

And black flickers worsen when change window size mode from Normal window to Maximum window.
(Uncheck "Show window contents while dragging" in Performance dialog of System properties of windows10 control panel)
#2 Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2e7460e2a73e061e3bc75646dc7d8b5e76943160&tochange=f5cc355f51aa846cbb998b5d49bafc2ead3bfa53

Comment 8

[Timothy Nikkel (:tnikkel)]

Alice, would you mind trying these builds and seeing how they perform. I'm trying to understand how bug 1574016 affects this.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=93c9267e41422a921584d94e977b10f3d15cf86d

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6065c609be8f6dd8f7c457dfbef1fdbf764f2c50

https://treeherder.mozilla.org/#/jobs?repo=try&revision=70740ed3da62aeea75da978a76e77ad8ba3fce15

https://treeherder.mozilla.org/#/jobs?repo=try&revision=acbec672a12ff10e65725d19affbacafc2fb92e2

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c776faa96093f36f426f1b3ea1ecc8230495558

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8043d9d3da80b7b81cf7a92748c7bc2218c780dc

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b45ba15e29b0f77285aed0e66fa8a91f3e72cf9c

Comment 9

[Alice0775 White]

(In reply to Timothy Nikkel (:tnikkel) from comment #8)

Alice, would you mind trying these builds and seeing how they perform. I'm trying to understand how bug 1574016 affects this.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=93c9267e41422a921584d94e977b10f3d15cf86d
*Very good, no longer flickering when maximized from normal size mode

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6065c609be8f6dd8f7c457dfbef1fdbf764f2c50
*Very good, no longer flickering when maximized from normal size mode

https://treeherder.mozilla.org/#/jobs?repo=try&revision=70740ed3da62aeea75da978a76e77ad8ba3fce15
*flickering when maximized from normal size mode

https://treeherder.mozilla.org/#/jobs?repo=try&revision=acbec672a12ff10e65725d19affbacafc2fb92e2
*flickering when maximized from normal size mode

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c776faa96093f36f426f1b3ea1ecc8230495558
*flickering when maximized from normal size mode

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8043d9d3da80b7b81cf7a92748c7bc2218c780dc
*no longer flickering when maximized from normal size mode, but sometimes, it flickers at first time.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b45ba15e29b0f77285aed0e66fa8a91f3e72cf9c
*flickering when maximized from normal size mode

Comment 10

[Jeff Muizelaar [:jrmuizel]]

What next Timothy?

Comment 11

[Timothy Nikkel (:tnikkel)]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #10)

What next Timothy?

Note that I was only investigating comment 7 which was caused by my patch, which seems kinda unrelated to this bug as filed in the first comment.

The only thing I determined was that we seem to be missing an invalidation in that step.

Alice, did the builds in comment 8 have any effect on resizing the browser window by dragging a window border?

Comment 12

[Alice0775 White]

(In reply to Timothy Nikkel (:tnikkel) from comment #11)

Alice, did the builds in comment 8 have any effect on resizing the browser window by dragging a window border?

same as the actual results of comment #0. i.e, no effect.

anyway, setting gfx.direct3d11.use-double-buffering to "false" mitigates the problem.

Comment 13

[Andrew Overholt [:overholt]]

Is there more to be done here?

Comment 14

[Jeff Muizelaar [:jrmuizel]]

Yes. This needs further investigation. Sotaro can you reproduce the problem?

Comment 15

[Sotaro Ikeda [:sotaro]]

As in Comment 12 , Black/White area could be related to DXGI_SWAP_EFFECT_FLIP_SEQUENTIAL SwapChain usage and compositor window usage. It looks similar to Bug 1494522. In this case, the symptom seems to related to cpu power.

chrome browser also uses DXGI_SWAP_EFFECT_FLIP_SEQUENTIAL SwapChain and child windows in gpu process if possible. It also has similar Black/White area symptom.

Comment 16

[Pascal Chevrel:pascalc]

We have shipped our last beta for 71 and this is a P3, so this is wontfix for 71.

Comment 17

[Julien Cristau [:jcristau]]

Double buffering was disabled at the last minute for 71 but is still enabled in 72. What's the plan here?

Comment 18

[Jeff Muizelaar [:jrmuizel]]

Alice, how much worse do find resizing in Firefox vs resizing in Chrome?

Comment 19

[Alice0775 White]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #18)

Alice, how much worse do find resizing in Firefox vs resizing in Chrome?

Black/White area appears temporarily.
However, it is almost same between Chromium 80.0.3972.0 and Nightly 73.0a1 20191213094653

If forcibly enabled WebRender, it is much better than Direct3D11(Advanced Layers).

So, I think this is now WONTFOX!

Comment 20

[Sotaro Ikeda [:sotaro]]

Thank you.