1579835 - Fix uses of ContentParent::mRemoteType when used with Fission

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P2)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1579835, part 1 - Make E10SUtils.isWebRemoteType use a simpler prefix approach.

Nika said that any `web'-prefixed remote type should be valid, so this
function can be simplified. For instance, webLargeAllocation should
return true.

This removes the need for ownerGlobal, so a few wrappers can be
removed.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1579835, part 2 - Add mozilla::dom::IsWebRemoteType.

This is the equivalent to E10SUtils.isWebRemoteType, except for C++.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1579835, part 3 - Fix ChromeUtils::RequestProcInfo() with Fission.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1579835, part 4 - Add a comment about why PushNotifier::Dispatch only matches "web".

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: Bug 1579835, part 5 - Fix remote type matching in SelectTargetActorForServiceWorker.

With Fission, the remote type can have the form webIsolated= in
addition to web. IsWebRemoteType() handles both of these cases.

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: Bug 1579835, part 1b - Directly pass in remote type to E10SUtils.isWebRemoteType.

Now that we only use a single field of the browser that gets passed in
to isWebRemoteType, I think it makes more sense to just pass in the
remote type directly.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0272eeb9b2ae
part 1 - Make E10SUtils.isWebRemoteType use a simpler prefix approach. r=mconley
https://hg.mozilla.org/integration/autoland/rev/2d7306573c04
part 1b - Directly pass in remote type to E10SUtils.isWebRemoteType. r=mconley
https://hg.mozilla.org/integration/autoland/rev/99fba9664c12
part 2 - Add mozilla::dom::IsWebRemoteType. r=nika
https://hg.mozilla.org/integration/autoland/rev/c0fb66a739a3
part 3 - Fix ChromeUtils::RequestProcInfo() with Fission. r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/b252a04d0093
part 4 - Add a comment about why PushNotifier::Dispatch only matches "web". r=asuth
https://hg.mozilla.org/integration/autoland/rev/fb0e1912da30
part 5 - Fix remote type matching in SelectTargetActorForServiceWorker. r=asuth

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/0272eeb9b2ae
https://hg.mozilla.org/mozilla-central/rev/2d7306573c04
https://hg.mozilla.org/mozilla-central/rev/99fba9664c12
https://hg.mozilla.org/mozilla-central/rev/c0fb66a739a3
https://hg.mozilla.org/mozilla-central/rev/b252a04d0093
https://hg.mozilla.org/mozilla-central/rev/fb0e1912da30

Comment 9

[Andrew McCreight [:mccr8]]

If this needs to get backed out for the service worker regressions, please trying just backing out part 5 first. That is the most directly service worker related patch.

Comment 10

[Andrew McCreight [:mccr8]]

Looks like the regressions might be due to another bug.