1579897 - about:support prints incorrect "Remote Processes" for webIsolated processes

Status: VERIFIED FIXED

(Toolkit :: General, defect)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Bug 1505322 added a "Remote Processes" box to about:support.

The data for this is generated in toolkit/modules/Troubleshoot.jsm by getting the remote types for each process:
remoteType = Services.ppmm.getChildAt(i).remoteType;

Then toolkit/locales/en-US/toolkit/global/processTypes.ftl is used to translate this. However, when Fission is enabled, the remote type is something like webIsolated=www.example.com which of course has no translation.

But wait, you say, shouldn't we have tests for this? We have at least one: dom/tests/browser/browser_beforeunload_between_chrome_content.js, that at least incidentally tests this. (Also browser_policy_disable_profile_reset.js and probably a lot more, given how many bc tests I see failing in my try run.)

This test opens an example.com URL, then opens about:support. However, this seems to implicitly rely on dom.ipc.keepProcessesAlive.web, which is set in BC tests, working.

Right now, this pref does not work with Fission enabled, so we seem to throw out example.com before we load about:support, so we never hit the assertion that a translation exists. In bug 1579835, I wrote a patch to make the pref work, which causes the test to start failing.

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Nika suggested that the remoteType get turned into webIsolated. I'm not sure exactly what the text string for that would be. As a separate thing, she suggested that there be a separate box in about:support that identifies what the domains are for each isolated process.

Comment 2

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: Bug 1579897 - Make webIsolated= processes work in about:support.

Remove the URLs so they can have a translated string in about:support.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed89fc2a60d8
Make webIsolated= processes work in about:support. r=mconley,fluent-reviewers,flod

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ed89fc2a60d8

Comment 5

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Hi Andrew, is there something that can be manually verified here?

Comment 6

[Andrew McCreight (out of office until 8/21) [:mccr8]]

(In reply to Catalin Sasca, QA [:csasca] from comment #5)

Hi Andrew, is there something that can be manually verified here?

This is a Fission-specific issue. You have to have Fission enabled, then load a regular webpage, then go to about:support. The "Remote Processes" section should have at least one entry where the Type is "Isolated Web Content".

Comment 7

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Ok Andrew, thanks for the fast reply!

Comment 8

[Alin Ilea, Desktop Test Engineering]

Reproduce the issue with an old Nightly build 71.0a1 (Build id: 20190909214621).
Verified - fixed on Nightly 71.0a1 (Build id: 20190926213542) and latest Nightly 72.0a1 (Build id: 20191128214853) on Windows 10, Ubuntu 18.04 and Mac OS 10.14.
On Beta 71 version, fission.autostart pref is blocked.