Closed Bug 1580400 Opened 5 years ago Closed 5 years ago

[Protections Panel] "None Detected" category item text color changes upon hover on Linux

Categories

(Firefox :: Site Identity, task, P1)

Product:
Firefox
Component:
Site Identity
Type:
task

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox70 --- verified
firefox71 --- verified

People

(Reporter: nhnt11, Assigned: timhuang)

References

Details

(Whiteboard: [privacy-panel][skyline][fixed by bug 1580106])

They should have no interaction styling since they are disabled.

Tim, can you take this? We can fix this in your patch for bug 1580106.

Assignee: nhnt11 → tihuang

Was this fixed? :)

Flags: needinfo?(tihuang)

In Bug 1580106, we changed the way how the hovering effect applies to toolbarbuttons in protections panel. It won't be applied to a disabled toolbarbutton. The text of the disabled button will still stay gray when hovering on it. So, this fixes this issue.

Flags: needinfo?(tihuang)

So, yes, this is fixed.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Depends on: 1580106
Resolution: --- → FIXED
Whiteboard: [privacy-panel][skyline] → [privacy-panel][skyline][fixed by bug 1580106]

I managed to reproduce the issue using an older version of Nightly (2019-09-10) on Ubuntu 18.04 x64.
I verified the fix using latest Nightly 71.0a1 and beta 70.0b9 on Ubuntu 18.04 x64, Windows 10 x64 and macOS 10.13. The bug is not reproducing anymore.

Status: RESOLVED → VERIFIED
status-firefox70: --- → verified
status-firefox71: fixed → verified
You need to log in before you can comment on or make changes to this bug.