1580130 - Differentiate networkID presence telemetry when the browser is online

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P1)

Description

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Currently our telemetry shows no networkID when the user's PC is disconnected from Wifi or when it goes into standby (as that turns off the wifi of the computer).
As a result we sometimes think that computing the network id fails even though that's not accurate.

We should add new probes for networkID that are only reported when Firefox is actually online/has connectivity.

Comment 1

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1580130 - Call calculateNetworkId() after every CheckAdaptersAddresses r=dragana

Since we sometimes coalesce SendEvents, calling it from there is not actually correct, and sometimes we fail to recompute the networkID when network changes happen.

Comment 2

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1580130 - Add telemetry to record presence of the networkID when the connectivity check has completed r=dragana

When the IPv4 check is completed, we get the network ID and report to telemetry if it was empty or not. This allows us to more accurately determine if we always have a networkID.

Depends on D45331

Comment 3

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: request.md

Comment 4

[Chris H-C :chutten]

Comment on attachment 9092581 [details]
request.md

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Valentin Gosu is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51670dc2c103
Call calculateNetworkId() after every CheckAdaptersAddresses r=dragana
https://hg.mozilla.org/integration/autoland/rev/992ba4bb048e
Add telemetry to record presence of the networkID when the connectivity check has completed r=dragana

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/51670dc2c103
https://hg.mozilla.org/mozilla-central/rev/992ba4bb048e