1580238 - Extend telemetry for QuotaManager initialization time

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Tom Tung [:tt, :ttung]]

QM_REPOSITORIES_INITIALIZATION_TIME is recorded until the end of 71. We want to extend it, but we can also consider adjusting some parameters.

Now the high and n_bucket are:
"high": 30000,
"n_buckets": 30

Some initial suggestions from the team is that: changing "high": 120000, but keep the "n_buckets" as what it is now (30).
Also, we could consider extending the current one and adding another one so that we can compare that without querying by ourselves.

In short:
Option one: Make another probe (QM_REPOSITORIES_INITIALIZATION_TIME_V2) and with high 120000 and n_buckets 30
Option two: Extend the current one and make another probe as well

Note: Jan might give other feedback so ni him below

Comment 1

[Jan Varga [:janv]]

I think we should extend the existing probe since we are going to ship new features that affect the initialization time significantly and we want to be able to easily compare it with old releases. 3 releases should be enough I guess.

I also think we need a new probe, because we don't know what is the worst storage initialization time. We just know that there's around 2-3% of samples with init time > 30s. So going from 30s to 120s should be enough.

Not sure about n_buckets, but it seems 50 is used by most of the probes in Histograms.json.

Comment 2

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1580238 - Extend the release for the prob of initialization time on QM and add another one to catch the longest time;

Comment 3

[Tom Tung [:tt, :ttung]]

Attachment: Data-review for extending the QM_REPOSITORIES_INITIALIZATION_TIME

Comment 4

[Tom Tung [:tt, :ttung]]

Attachment: Data-review for adding QM_REPOSITORIES_INITIALIZATION_TIME_V2

Comment 5

[Chris H-C :chutten]

Comment on attachment 9092020 [details]
Data-review for extending the QM_REPOSITORIES_INITIALIZATION_TIME

Load-balancing to Teon.

Comment 6

[Teon Brooks [:teon]]

Comment on attachment 9092022 [details]
Data-review for adding QM_REPOSITORIES_INITIALIZATION_TIME_V2

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Fx 77.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :ttung is responsible for renewing or removing the collection before it expires in Fx 77.

---
Result: datareview

Comment 7

[Tom Tung [:tt, :ttung]]

Hi Teon,

needinfo'ing, in the case of you accidentally missing the other data-review request for extending the existing telemetry.

Attachment #9092020 [details] is for extending the existing telemetry probe (QM_REPOSITORIES_INITIALIZATION_TIME). Please feel free to let me know if that doesn't need a data-review or I should put it on another bug, or something else. Thanks!

Comment 8

[Teon Brooks [:teon]]

Comment on attachment 9092020 [details]
Data-review for extending the QM_REPOSITORIES_INITIALIZATION_TIME

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire Fx 75.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :ttung is responsible for renewing or removing the collection before it expires Fx 75.

---
Result: datareview

Comment 9

[Teon Brooks [:teon]]

(In reply to Tom Tung [:tt, :ttung] from comment #7)

Hi Teon,

needinfo'ing, in the case of you accidentally missing the other data-review request for extending the existing telemetry.

Attachment #9092020 [details] is for extending the existing telemetry probe (QM_REPOSITORIES_INITIALIZATION_TIME). Please feel free to let me know if that doesn't need a data-review or I should put it on another bug, or something else. Thanks!

thanks for the flag. completed both forgot to submit the second one yesterday

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d435f837f1c
Extend the release for the prob of initialization time on QM and add another one to catch the longest time; r=janv,sg

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2d435f837f1c