Closed
Bug 158038
Opened 22 years ago
Closed 20 years ago
minor comment changes in nsIWebBrowserPrint (print and printPreview)
Categories
(Core Graveyard :: Embedding: APIs, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0.1
People
(Reporter: depman1, Assigned: rods)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.34 KB,
patch
|
rods
:
review+
rods
:
superreview+
|
Details | Diff | Splinter Review |
The first parameter for print() and printPreview() are incorrect in the comments
of nsIWebBrowserPrint.idl. aThePrintOptions should be changed to aThePrintSettings.
|
Assignee | |
Comment 1•22 years ago
|
||
minor comments change
|
|
Assignee | |
Updated•22 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0.1
|
||
Comment 2•22 years ago
|
||
Comment on attachment 91776 [details] [diff] [review]
patch
r=dcone
Attachment #91776 -
Flags: review+
Comment on attachment 91776 [details] [diff] [review]
patch
For consistency and javadoc parsing, parameters in api comments should start
with @param like the one for enumerateDocumentNames() in that same file.
Should we take care of this in the same checkin?
sr=kin@netscape.com on your param renaming in the comment.
Attachment #91776 -
Flags: superreview+
|
|
Assignee | |
Comment 4•22 years ago
|
||
Patch with Kin's suggestions
Attachment #91776 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•22 years ago
|
||
Comment on attachment 91963 [details] [diff] [review]
patch
bringing r & sr forward
Attachment #91963 -
Flags: superreview+
Attachment #91963 -
Flags: review+
mozilla/embedding/browser/webBrowser/nsIWebBrowserPrint.idl 1.21
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 7•20 years ago
|
||
verified in idl file. There's still an extra param listed for cancel(), will
submit another bug for that one.
Status: RESOLVED → VERIFIED
|
|
Reporter | |
Comment 8•20 years ago
|
||
bug 252011 for removing the cancel() parameter comment.
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•