Remove extra param in comments section for cancel() in nsIWebBrowserPrint.idl

RESOLVED FIXED

Status

()

Core
Printing: Output
--
minor
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: David Epstein, Assigned: Daniel Kraft)

Tracking

({helpwanted})

Trunk
x86
Windows XP
helpwanted
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

14 years ago
nsIWebBrowserPrint.idl:
There's no @param Cancel in cancel(); it has no parameters. 
The comment should be removed.
Keywords: helpwanted
Whiteboard: [good first bug]

Updated

14 years ago
Depends on: 158038
To Elliot, per his request.
Assignee: printing → elliot.lee
(Assignee)

Comment 2

14 years ago
Created attachment 171566 [details] [diff] [review]
Removed comment

You thought of something like this?
Attachment #171566 - Flags: review?(bzbarsky)
Daniel, in general more context makes patches easier to review... -up8 are good
options for making a diff.
(Assignee)

Comment 4

14 years ago
Of course, normally I use -u8, but not when just changing a comment...
(Or should I even then?)
Well, I can't tell whether this change is correct, because I can't see the
function declaration in the diff, nor the rest of the comment... so yes, you
should use enough context to make the patch reviewable any time you make a
patch.  ;)
(Assignee)

Comment 6

14 years ago
Created attachment 171649 [details] [diff] [review]
Context 8 lines

Oh, I see. That's reason enough...
Sorry!
Attachment #171566 - Attachment is obsolete: true
Attachment #171649 - Flags: review?(bzbarsky)
Comment on attachment 171649 [details] [diff] [review]
Context 8 lines

Ah, thank you.	r+sr=bzbarsky; I'll check this in when the tree opens.
Attachment #171649 - Flags: superreview+
Attachment #171649 - Flags: review?(bzbarsky)
Attachment #171649 - Flags: review+

Comment 8

14 years ago
Comment on attachment 171649 [details] [diff] [review]
Context 8 lines

>+   * Cancels the current print 
current print *what*?

It's best if the documentation be written in English.
(Assignee)

Comment 9

14 years ago
I'm sorry, but that's what already was present in the original file. Would you
prefer to see "the current print job" or something like that?
Assignee: elliot.lee → domob
Fixed for 1.8b.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Comment 11

14 years ago
i dunno, does it mean that? does it only cancel prints and not previews? if what
you wrote is what it means, then yes i'd rather see that.
(Assignee)

Comment 12

14 years ago
I also don't know what it means exactly. As I wrote, that is, what was already
present in the file. I've just removed the missplaced @param.
You need to log in before you can comment on or make changes to this bug.