nsIWebBrowserPrint.idl: There's no @param Cancel in cancel(); it has no parameters. The comment should be removed.
Whiteboard: [good first bug]
To Elliot, per his request.
Assignee: printing → elliot.lee
Created attachment 171566 [details] [diff] [review] Removed comment You thought of something like this?
Daniel, in general more context makes patches easier to review... -up8 are good options for making a diff.
Of course, normally I use -u8, but not when just changing a comment... (Or should I even then?)
Well, I can't tell whether this change is correct, because I can't see the function declaration in the diff, nor the rest of the comment... so yes, you should use enough context to make the patch reviewable any time you make a patch. ;)
Created attachment 171649 [details] [diff] [review] Context 8 lines Oh, I see. That's reason enough... Sorry!
Comment on attachment 171649 [details] [diff] [review] Context 8 lines Ah, thank you. r+sr=bzbarsky; I'll check this in when the tree opens.
Comment on attachment 171649 [details] [diff] [review] Context 8 lines >+ * Cancels the current print current print *what*? It's best if the documentation be written in English.
I'm sorry, but that's what already was present in the original file. Would you prefer to see "the current print job" or something like that?
Assignee: elliot.lee → domob
Fixed for 1.8b.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
i dunno, does it mean that? does it only cancel prints and not previews? if what you wrote is what it means, then yes i'd rather see that.
I also don't know what it means exactly. As I wrote, that is, what was already present in the file. I've just removed the missplaced @param.
You need to log in before you can comment on or make changes to this bug.