1580432 - File-url's not allowed in Home Top Sites

Status: NEW

(Firefox :: New Tab Page, defect, P3)

Description

[steven.goris+bugzilla]

Attachment: Screenshot 2019-09-11 at 11.09.36.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

I wanted to add a URL to a local html page to the top sites section.
The URL starts with the file:// protocol.

Actual results:

A validation error appears "Valid URL required"

Expected results:

The URL should have been accepted, because it is a valid URL.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Artur Akerberg]

Attachment: Bug 1580432 - Remove the http\s restriction on sites in the new tab r=Mardak

This patch allow This patch allows to add site links and icons using the
"file:", "data:" and "moz-extension:" scheme.

This addresses bugs:
1763958
1580432
1397242
1448909

Comment 3

[Damian Yerrick]

I'm still seeing this misbehavior (and similar bug 1607800) in Firefox 114.0.1 (64-bit) snap on Xubuntu 23.04.

The workaround for New Tab not supporting file: is the same as the workaround for file: not supporting CORS. Run an HTTP server process in the background on the user's computer serving HTML documents that can be accessed from the New Tab page. The user may want to make sure the server listens only to localhost.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 6

[Artur Akerberg]

Attachment: Bug 1580432 - Remove the http\s restriction on sites in the new tab r=Mardak

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.