1580533 - Compile Firefox 70 fails with MOZ_CONFIGURE_OPTIONS value is not unicode.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Alan Robertson]

Attachment: Firefox 70 compile fail

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

https://ftp.mozilla.org/pub/firefox/releases/
Download and unpack firefox-70.0b5.source.tar.xz
mkdir ff && cd ff
cargo install cbindgen --force
../configure --with-clang-path=/usr/bin/clang-8

Actual results:

....
js/src> creating ./config.data
js/src> Creating config.status
MOZ_CONFIGURE_OPTIONS value is not unicode.
substs value is not unicode.
Configuration should be all unicode.
Please file a bug for the above.

Expected results:

make -j9
sudo make install

Firefox 69.0b9 compiles fine on same computer.
Linux Mint 19, kernel 5.3.0-050300rc8-generic

Comment 1

[Virginia (please send need info request to Brindusa Tot)]

Hi Alan Robertson,

Thank you for your report.

Unfortunately, I don't have the Linux version to test this on my end, but as a starting point, I'll add a product and component so the devs can take a look at this and investigate.

Regards,

Comment 2

[Alan Robertson]

Just a quick follow up - just tried firefox-70.0b9 and the same issue is present:

https://ftp.mozilla.org/pub/firefox/releases/70.0b9/source/firefox-70.0b9.source.tar.xz

MOZ_CONFIGURE_OPTIONS value is not unicode

This appears in:
/firefox-70.0b9.source/firefox-70.0/toolkit/moz.configure
/firefox-70.0b9.source/firefox-70.0/toolkit/content/moz.build

Not sure what the problem is.
node --version
v10.16.3
cargo --version
cargo 1.39.0-nightly (fe0e5a48b 2019-09-04)

The good news is that Mach seems to work perfectly:

./mach build
sudo ./mach install

firefox --version
Mozilla Firefox 70.0b9

Awesome! Mach it is then.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1580533 - Ensure MOZ_CONFIGURE_OPTIONS is unicode.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/989e51b08291
Ensure MOZ_CONFIGURE_OPTIONS is unicode. r=chmanchester

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 9097540 [details]
Bug 1580533 - Ensure MOZ_CONFIGURE_OPTIONS is unicode.

Beta/Release Uplift Approval Request

• User impact if declined: Build failure in some setups
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Build system change only. No-op in most cases.
• String changes made/needed: N/A

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/989e51b08291

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9097540 [details]
Bug 1580533 - Ensure MOZ_CONFIGURE_OPTIONS is unicode.

Build related fix, OK for beta 12 uplift.

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ca06dcc43bb7

Comment 9

[Daniel Varga [:dvarga]]

Backed out changeset ca06dcc43bb7 (Bug 1580533) for build bustage in ensure_unicode a=backout

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=b63b75ad69b6a5a7d72811a9971f0f7555379905

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269498698&repo=mozilla-beta&lineNumber=1024

Backout link: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=24de1dfb60861c82f36c75e700d843cf75081adc

[task 2019-10-02T19:50:44.252Z] 19:50:44    ERROR -  Traceback (most recent call last):
[task 2019-10-02T19:50:44.252Z] 19:50:44     INFO -    File "/builds/worker/workspace/build/src/configure.py", line 164, in <module>
[task 2019-10-02T19:50:44.252Z] 19:50:44     INFO -      sys.exit(main(sys.argv))
[task 2019-10-02T19:50:44.252Z] 19:50:44     INFO -    File "/builds/worker/workspace/build/src/configure.py", line 40, in main
[task 2019-10-02T19:50:44.252Z] 19:50:44     INFO -      sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
[task 2019-10-02T19:50:44.252Z] 19:50:44     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/configure/__init__.py", line 498, in run
[task 2019-10-02T19:50:44.252Z] 19:50:44     INFO -      func(*args)
[task 2019-10-02T19:50:44.252Z] 19:50:44     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/configure/__init__.py", line 542, in _value_for
[task 2019-10-02T19:50:44.252Z] 19:50:44     INFO -      return self._value_for_depends(obj)
[task 2019-10-02T19:50:44.253Z] 19:50:44     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/util.py", line 963, in method_call
[task 2019-10-02T19:50:44.253Z] 19:50:44     INFO -      cache[args] = self.func(instance, *args)
[task 2019-10-02T19:50:44.253Z] 19:50:44     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/configure/__init__.py", line 551, in _value_for_depends
[task 2019-10-02T19:50:44.253Z] 19:50:44     INFO -      value = obj.result()
[task 2019-10-02T19:50:44.253Z] 19:50:44     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/util.py", line 963, in method_call
[task 2019-10-02T19:50:44.253Z] 19:50:44     INFO -      cache[args] = self.func(instance, *args)
[task 2019-10-02T19:50:44.253Z] 19:50:44     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/configure/__init__.py", line 157, in result
[task 2019-10-02T19:50:44.253Z] 19:50:44     INFO -      return self._func(*resolved_args)
[task 2019-10-02T19:50:44.253Z] 19:50:44     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/configure/__init__.py", line 1156, in wrapped
[task 2019-10-02T19:50:44.253Z] 19:50:44     INFO -      return new_func(*args, **kwargs)
[task 2019-10-02T19:50:44.253Z] 19:50:44     INFO -    File "/builds/worker/workspace/build/src/toolkit/moz.configure", line 33, in all_configure_options
[task 2019-10-02T19:50:44.253Z] 19:50:44     INFO -      system_encoding))
[task 2019-10-02T19:50:44.253Z] 19:50:44    ERROR -  TypeError: ensure_unicode() takes exactly 1 argument (2 given)
[task 2019-10-02T19:50:44.289Z] 19:50:44     INFO -  *** Fix above errors and then restart with\
[task 2019-10-02T19:50:44.289Z] 19:50:44     INFO -                 "./mach build"
[task 2019-10-02T19:50:44.289Z] 19:50:44     INFO -  client.mk:111: recipe for target 'configure' failed
[task 2019-10-02T19:50:44.289Z] 19:50:44     INFO -  make: *** [configure] Error 1
[task 2019-10-02T19:50:44.389Z] 19:50:44    ERROR - Return code: 2
[task 2019-10-02T19:50:44.389Z] 19:50:44  WARNING - setting return code to 2
[task 2019-10-02T19:50:44.389Z] 19:50:44    FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2019-10-02T19:50:44.389Z] 19:50:44    FATAL - Running post_fatal callback...
[task 2019-10-02T19:50:44.389Z] 19:50:44    FATAL - Exiting -1

Comment 10

[Mike Hommey [:glandium]]

That comes from having a hidden dependency on a part of bug 1577826.

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2024b530c79b