1575135 - Only allow Unicode strings out of the python configure sandbox

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1575135 - Remove unused subprocess imports.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1575135 - Define whether the system encoding is mbcs or utf-8 once.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1575135 - Fix mock_pkg_config failure case.

It only happens when things go badly, which is why it doesn't cause
problems, but when moving things around, triggering the error, we
currently get a formatting error rather than the actual error.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1575135 - Use functions from util.configure instead of subprocess.*.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1575135 - Change get_cmd_output to emit unicode strings.

Because most calling places in python configure don't actually want to
deal with encodings, although in practical terms they should, make
get_cmd_output handle it itself.

Places that explicitly do want bytes can keep using subprocess directly.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1575135 - Make configure sandbox open() look more like python 3's.

As a consequence, we can replace the encoded_open function that did the
same in an opt-in manner.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1575135 - Return an unicode path for nodejs.

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1575135 - Make configure complain on non-unicode strings.

Make it a hard error when the sandbox returns non-unicode strings.
This should help quickly catch any remaining non-unicode string that
are not caught by automation.

Comment 9

[Mike Hommey [:glandium]]

Attachment: Bug 1575135 - Don't encode environment in get_cmd_output and old_configure.

The configure sandbox has wrapped subprocess methods to do it since
bug 1520394.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0b2831af074
Remove unused subprocess imports. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/38e02cd63d8d
Define whether the system encoding is mbcs or utf-8 once. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/fd9f4d8f171b
Fix mock_pkg_config failure case. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/f3e3d13c202a
Use functions from util.configure instead of subprocess.*. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/9b73ac45f717
Change get_cmd_output to emit unicode strings. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/2139ee18939e
Make configure sandbox open() look more like python 3's. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/7e4b8df1e96a
Return an unicode path for nodejs. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/b651185f9573
Make configure complain on non-unicode strings. r=nalexander

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/e0b2831af074
https://hg.mozilla.org/mozilla-central/rev/38e02cd63d8d
https://hg.mozilla.org/mozilla-central/rev/fd9f4d8f171b
https://hg.mozilla.org/mozilla-central/rev/f3e3d13c202a
https://hg.mozilla.org/mozilla-central/rev/9b73ac45f717
https://hg.mozilla.org/mozilla-central/rev/2139ee18939e
https://hg.mozilla.org/mozilla-central/rev/7e4b8df1e96a
https://hg.mozilla.org/mozilla-central/rev/b651185f9573