Closed Bug 1580573 Opened 7 years ago Closed 7 years ago

RecipeRunner.attachRemoteSettings missing await

Categories

(Firefox :: Normandy Client, defect)

Product:
Firefox
Component:
Normandy Client
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: rhelmer, Assigned: rhelmer)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1580573 - Normandy RecipeRunner missing await r?mythmon,leplatrem
47 bytes, text/x-phabricator-request
Details | Review

Currently, RecipeRunner.attachRemoteSettings does not await the async function this.run():

https://searchfox.org/mozilla-central/rev/588814f2edddf0e132d77d326ddae50911e8bad1/toolkit/components/normandy/lib/RecipeRunner.jsm#241

This is not harmful per se, but it means that the when the FirstStartup service (added in bug 1576507) cannot tell when Normandy is completely done running recipes, which makes it much less useful for first-run experiments :)

Blocks: 1571777
Pushed by rhelmer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/24ae52d6576e Normandy RecipeRunner missing await r=leplatrem

https://hg.mozilla.org/mozilla-central/rev/24ae52d6576e

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: