Closed Bug 1580752 Opened 1 year ago Closed 6 months ago

Fire RemoteWebProgress onLocationChange for subframe location changes

Categories

(Core :: DOM: Navigation, task, P2)

task

Tracking

()

RESOLVED WONTFIX
Fission Milestone M4.1

People

(Reporter: kashav, Assigned: kashav)

References

(Blocks 1 open bug)

Details

This came up while working on bug 1578465.

We currently don't fire onLocationChange for remote subframe location changes.

No longer blocks: 1541173
Fission Milestone: --- → M4
Component: Mochitest → Document Navigation
Priority: -- → P2
Product: Testing → Core
Version: Version 3 → unspecified
No longer blocks: 1578465

I assume this will include OnContentBlockEvent too? We need that for bug 1590696.

Blocks: 1590696

This is in-turn blocking the trackingUI M-fis tests.

Fission Milestone: M4 → M4.1
Assignee: kmadan → kmaglione+bmo
No longer blocks: 1590696

Kris, are you still working on this onLocationChange bug? It's blocking some M4.1 mochitests (such as bug 1592777). Can we delegate this bug to a different Fission engineer?

Flags: needinfo?(kmaglione+bmo)

(In reply to Chris Peterson [:cpeterson] from comment #3)

Kris, are you still working on this onLocationChange bug? It's blocking some M4.1 mochitests (such as bug 1592777). Can we delegate this bug to a different Fission engineer?

Not actively. My understanding is that it's not currently blocking anything, so it hasn't been a high priority. If it is blocking something, someone will need to explain to me what and why.

Flags: needinfo?(kmaglione+bmo)

(In reply to Kris Maglione [:kmag] from comment #4)

Not actively. My understanding is that it's not currently blocking anything, so it hasn't been a high priority. If it is blocking something, someone will need to explain to me what and why.

Ethan Tseng told me (three months ago, bug 1592777 comment 3) the browser_popupNotification_3.js test (bug 1592777) was blocked waiting for this onLocationChange fix. I will confirm with MattN, triage owner for that popup test.

cpeterson will confirm why browser_popupNotification_3.js test (bug 1592777) needs this onLocationChange change.

unassigning kmag in the meantime

Assignee: kmaglione+bmo → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(cpeterson)
Flags: needinfo?(cpeterson)

(In reply to Chris Peterson [:cpeterson] from comment #6)

cpeterson will confirm why browser_popupNotification_3.js test (bug 1592777) needs this onLocationChange change.

The test needs location change events because it is testing that a location change in a background tab dismisses a notification and that a location change in an embedded frame does not.

https://searchfox.org/mozilla-central/rev/61fceb7c0729773f544a9656f474e36cd636e5ea/browser/base/content/test/popupNotifications/browser_popupNotification_3.js#305

@ Matt, IIRC you were proposing some changes to RemoteWebProgress a couple months ago. What is the current state of RemoteWebProgress and Fission? Is there an alternative tests should use?

Flags: needinfo?(matt.woodrow)

Can we listen for the "window-global-created" observer notification, that fires when we create a new WindowGlobalParent (and make it the current window for a BrowsingContext)?

Flags: needinfo?(matt.woodrow)

Assigning to Kashav because he volunteered to work on this bug.

Assignee: nobody → kmadan
No longer blocks: 1592777

Ended up going with the thing Matt suggested in comment #8 for bug 1592777. This bug has no other dependencies, so we probably don't actually need this. We can re-open if it's needed in the future.

Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.