1592777 - Fix browser/base/content/test/popupNotifications/browser_popupNotification_3.js for fission

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, task, P2)

Description

[David Durst [:ddurst]]

Currently browser/base/content/test/popupNotifications/browser_popupNotification_3.js is skipped for opt and debug.

Comment 1

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 2

[Chris Peterson [:cpeterson]]

Ethan says this test is blocked waiting for RemoteWebProgress onLocationChange bug 1580752.

Comment 3

[Chris Peterson [:cpeterson]]

Matt, this bug is a blocker for Fission's M.1 milestone (aka "fix all the mochitests"), but it's currently unassigned. The Fission team is hoping teams will fix their mochitests for Fission before the end of Q1 (75 or 76 Nightly).

Is this bug blocked waiting for RemoteWebProgress onLocationChange bug 1580752 (as I reported in comment 2 that Ethan Tseng said)? kmag said (in bug 1580752 comment 4) that he doesn't think bug 1580752 is blocking anything.

Will your team be able to prioritize this bug for Q1? If you don't think this mochitest failure should block shipping Fission, just let me know.

Comment 4

[Matthew N. [:MattN]]

I haven't had time to look into this test.

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Chris Peterson [:cpeterson] from comment #3)

Is this bug blocked waiting for RemoteWebProgress onLocationChange bug 1580752 (as I reported in comment 2 that Ethan Tseng said)? kmag said (in bug 1580752 comment 4) that he doesn't think bug 1580752 is blocking anything.

The test needs location change events (Fission bug 1580752) because it is testing that a location change in a background tab dismisses a notification and that a location change in an embedded frame does not.

https://searchfox.org/mozilla-central/rev/61fceb7c0729773f544a9656f474e36cd636e5ea/browser/base/content/test/popupNotifications/browser_popupNotification_3.js#305

This bug is still a blocker enabling Fission in Nightly.

Comment 6

[u608768]

Attachment: Bug 1592777 - Make browser_popupNotification_3.js fission-compatible, r?MattN

We don't send WebProgress location change events for remote subframe
navigations, so listen for a new WindowGlobalParent instead.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08b7145522f6
Make browser_popupNotification_3.js fission-compatible, r=MattN

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/08b7145522f6