Closed Bug 1581000 Opened 6 years ago Closed 6 years ago

Turn on Rust version of Cubeb AudioUnit by default in Nightly

Categories

(Core :: Audio/Video: cubeb, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Turn on the audiounit-rust backend by default in Nightly

Blocks: 1530713

The current version of cubeb-rs in gecko is 0.5.5. The required version of cubeb-rs in newest cubeb-coreaudio-rs is 0.6.

Perhaps we can turn on the audiounit-rust after solving bug 1574284 and bug 1575638, so we can bump up the version of cubeb-rs.

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:chunmin, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(cchang)

The plan is to turn on it in Nightly after cubeb-backend is bumped to 0.6.

Flags: needinfo?(cchang)
Keywords: checkin-needed

(In reply to C.M.Chang[:chunmin] from comment #4)

The plan is to turn on it in Nightly after cubeb-backend is bumped to 0.6.

cubeb is bumped in bug 1575883, so it's time to turn on the rust version and see what happens.

Patch failed to land: "We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. applying /tmp/tmp3PUuZ6 modules/libpref/init/all.js Hunk #1 FAILED at 644. 1 out of 1 hunk FAILED -- saving rejects to file modules/libpref/init/all.js.rej abort: patch command failed: exited with status 256"

Flags: needinfo?(cchang)
Keywords: checkin-needed
Attachment #9092516 - Attachment description: Bug 1581000 - Turn on audiounit-rust by default in Nightly. r?padenot → Bug 1581000 - Turn on audiounit-rust by default in Nightly. r=padenot

(In reply to Razvan Maries from comment #6)

Patch failed to land: "We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. applying /tmp/tmp3PUuZ6 modules/libpref/init/all.js Hunk #1 FAILED at 644. 1 out of 1 hunk FAILED -- saving rejects to file modules/libpref/init/all.js.rej abort: patch command failed: exited with status 256"

The patch is rebased.

Flags: needinfo?(cchang)
Keywords: checkin-needed

Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c116c122cc6f
Turn on audiounit-rust by default in Nightly. r=padenot

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Regressions: 1589514
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: