158103 - Copying and pasting HTML includes "<!-- Start Fragment -->"

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[:deanis74]

From bug 157994...

Actually, i think we do this wrong anyway.  StartFragment:<n> should point to
the first character _after_ <!-- StartFragment -->.  If I copy text from Moz and
paste it into an HTML message in Outlook Express, the source contains "<!--
StartFragment -->"

After 157994 is fixed, cleaning up the code, this bug needs to be fixed.

Comment 1

[Joe Francis]

i noticed this too when working on the cfhtml paste patch.  at the moment my 
patch will strip out the comments regardless of which side of the "line" they are 
on.

Comment 2

[timeless]

*** Bug 258546 has been marked as a duplicate of this bug. ***

Comment 3

[timeless]

*** Bug 226789 has been marked as a duplicate of this bug. ***

Comment 4

[Daniel Atallah]

Attachment: Proposed patch to fix the win32 HTML Clipboard population

(i originally had this attached to Bug #258546, which i, despite my best
efforts to find a duplicate, entered as a duplicate of this)
This seems like simple solution to the bug.
3 main changes:

1-The main issue that this fixes is that it changes the StartFragment offset to
after the <!--StartFragment--> tag instead of before it.
2-It also removes the incorrect ' ' that was between "<!--StartFragment" and
"-->"
3-Remove the added "\r\n" before and after the actual text fragment (these are
not part of the actual fragment and shouldn't be there)

I realize that the code is going to be re-written (Bug #157994), but i don't
see a reason that this fix shouldn't go in in the meantime.

Comment 5

[timeless]

*** Bug 216029 has been marked as a duplicate of this bug. ***

Comment 6

[Daniel Atallah]

This was fixed (in CVS trunk, and 1.7.5) as part of the fix for Bug 157994. 
Since this fixed this on the 1.7 branch, somebody who can should add the
"fixed1.7.5" keyword.  (Somebody who can should also mark this as RESOLVED).

Comment 7

[Daniel Atallah]

(In reply to comment #6)
> This was fixed (in CVS trunk, and 1.7.5) as part of the fix for Bug 157994. 
> Since this fixed this on the 1.7 branch, somebody who can should add the
> "fixed1.7.5" keyword.  (Somebody who can should also mark this as RESOLVED).

I don't usually talk to myself, but i can now close this bug and add the keyword.

Comment 8

[u584929]

How to solve that "StartFragment" issue with the last version of firefox?