1581096 - Search panel engine icon is not aligned with the magnifying glass and clock icons

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Itiel]

Attachment: Screenshot

This is a regression from bug 1561894.
See attached.

Comment 1

[Harry Twyford]

Attachment: Bug 1581096 - Align search panel engine icon with clock icons. r?dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d552aa97a41
Align search panel engine icon with clock icons. r=dao

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3d552aa97a41

Comment 4

[Julien Cristau [:jcristau]]

Is this worth uplifting to 70? Please file the request if so.

Comment 5

[Harry Twyford]

Comment on attachment 9092846 [details]
Bug 1581096 - Align search panel engine icon with clock icons. r?dao

Beta/Release Uplift Approval Request

• User impact if declined: UI misalignment in the standalone search bar.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Enter a search query in the standalone search bar. Then enter it again, so that it's in recent history. Observe if the history clock icon is aligned with the search engine logo at the top of the panel.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS-only change in the standalone search bar.
• String changes made/needed:

Comment 6

[Md. Majedul islam]

I have reproduced this bug with Nightly 71.0a1 (2019-09-10) on windows 10, 64 bit!

The fix is now verified on Latest Nightly 71.0a1 (2019-09-23)

Build ID : 20190923215658
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0

Comment 7

[Anca Soncutean, Desktop QA]

(In reply to Md. Majedul islam from comment #6)

The fix is now verified on Latest Nightly 71.0a1 (2019-09-23)

Thank you for testing! I can also confirm the fix with Nightly 71.0a1 (2019-09-23) on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9092846 [details]
Bug 1581096 - Align search panel engine icon with clock icons. r?dao

Fix for new regression, verified in Nightly, let's take this for beta 10.

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/d7a88a4fb295

Comment 10

[Anca Soncutean, Desktop QA]

The issue is verified fixed with Fx 70.0b10 (treeherder build provided in the comment above) on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 x64.