1581278 - Add a version of Promise::MaybeReject that takes an nsresult and a error message

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Boris Zbarsky [:bzbarsky]]

Or maybe we should call it MaybeRejectWithDOMException to make it clear what's going on here?

All the callsites at https://searchfox.org/mozilla-central/search?q=MaybeReject%28NS_ERROR_DOM&path= are rather suspect and maybe in need of changing to the new setup.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1581278 part 1. Implement ErrorResult overload of DetailedPromise::MaybeReject. r=bholley

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1581278 part 2. Add convenience methods for rejecting promises with various types of spec exceptions. r=smaug

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1581278 part 3. Stop incorrectly rejecting promises in storage manager. r=janv

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1581278 part 4. Stop incorrectly rejecting promises in MediaCapabilities. r=jya

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1581278 part 5. Stop incorrectly rejecting promises in EME. r=bryce

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0861c66c0e4c
part 1.  Implement ErrorResult overload of DetailedPromise::MaybeReject.  r=bholley
https://hg.mozilla.org/integration/autoland/rev/f3eb9ec9f7b9
part 2.  Add convenience methods for rejecting promises with various types of spec exceptions.  r=smaug
https://hg.mozilla.org/integration/autoland/rev/48603e8781d8
part 3.  Stop incorrectly rejecting promises in storage manager.  r=janv
https://hg.mozilla.org/integration/autoland/rev/7399098308aa
part 4.  Stop incorrectly rejecting promises in MediaCapabilities.  r=jya
https://hg.mozilla.org/integration/autoland/rev/dd375f633fe7
part 5.  Stop incorrectly rejecting promises in EME.  r=bryce

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/19225 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/19225
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/d0NCKH1CSaiicEpsU0eomA)

Comment 9

[Boris Zbarsky [:bzbarsky]]

I can't quite tell from the logs this time what the issue is, but if it's the timeouts in encrypted-media/drm-mp4-playback-retrieve-destroy-persistent-license.https.html and similar, those predate these changes, right?

Comment 10

[Boris Zbarsky [:bzbarsky]]

An in particular, see bug 1313284.

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0861c66c0e4c
https://hg.mozilla.org/mozilla-central/rev/f3eb9ec9f7b9
https://hg.mozilla.org/mozilla-central/rev/48603e8781d8
https://hg.mozilla.org/mozilla-central/rev/7399098308aa
https://hg.mozilla.org/mozilla-central/rev/dd375f633fe7

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham