Get rid of NS_ERROR_TYPE_ERR
Categories
(Core :: DOM: Core & HTML, defect, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: emk, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
This is confusing and sometimes misused (see bug 926890).
|
Reporter | |
Updated•11 years ago
|
|
||
Comment 1•6 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046 Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5. If you have questions, please contact :mdaly.
|
Assignee | |
Comment 2•6 years ago
|
||
We should fix this, imo. It's causing us to have spec-compliance bugs because people get confused and use NS_ERROR_TYPE_ERR. See bug 1472095. We need to kill NS_ERROR_DOM_TYPE_ERR too...
|
|
Assignee | |
Updated•6 years ago
|
|
||
Updated•6 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
I filed bug 1581172 on NS_ERROR_DOM_TYPE_ERR.
|
|
Assignee | |
Comment 4•5 years ago
|
||
The only ways DispatchReceivedData can fail are if our scope is torn down, we
OOM when creating a typed array, or we fail to queue a runnable. These all
seem like pretty unexpected situations, so NS_ERROR_UNEXPECTED seems
appropriate if we don't want to just propagate through the error from
DispatchReceivedData.
|
|
Assignee | |
Comment 5•5 years ago
|
||
The actual return code we return here doesn't really matter, since there is
already an exception on the JSContext. NS_ERROR_UNEXPECTED is as good as
anything, since we don't expect bogus options.
|
|
Assignee | |
Comment 6•5 years ago
|
||
NS_ERROR_DOM_TYPE_ERR is not much better, but this at least allows us to get
rid of NS_ERROR_TYPE_ERR completely...
|
||
Updated•5 years ago
|
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/578478de9488 part 1. Stop using NS_ERROR_TYPE_ERR in UDPSocket. r=smaug https://hg.mozilla.org/integration/autoland/rev/857146a2bb00 part 2. Stop using NS_ERROR_TYPE_ERR in windowutils. r=smaug https://hg.mozilla.org/integration/autoland/rev/93327435846a part 3. Stop using NS_ERROR_TYPE_ERR in serviceworker code. r=smaug
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/578478de9488
https://hg.mozilla.org/mozilla-central/rev/857146a2bb00
https://hg.mozilla.org/mozilla-central/rev/93327435846a
Description
•