1581279 - mach clobber --full throws python exception

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

╰─$ ./mach clobber --full                                                                                                                                                                                                                    
Error running mach:

    ['clobber', '--full']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: Can't mix strings and bytes in path components

  File "/home/emilio/src/moz/gecko/python/mozbuild/mozbuild/mach_commands.py", line 210, in clobber
    Clobberer(self.topsrcdir, self.topobjdir, self.substs).remove_objdir(full)
  File "/home/emilio/src/moz/gecko/python/mozbuild/mozbuild/controller/clobber.py", line 161, in remove_objdir
    self.delete_dirs(self.topobjdir, paths)
  File "/home/emilio/src/moz/gecko/python/mozbuild/mozbuild/controller/clobber.py", line 122, in delete_dirs
    path = os.path.join(root, p)
  File "/usr/lib64/python3.7/posixpath.py", line 94, in join
    genericpath._check_arg_types('join', a, *p)
  File "/usr/lib64/python3.7/genericpath.py", line 151, in _check_arg_types
    raise TypeError("Can't mix strings and bytes in path components") from None

Comment 1

[Chris Manchester (limited bugmail, email directly)]

This would seem to be fallout from bug 1473498.

Comment 2

[Michael Shal [:mshal]]

Attachment: Bug 1581279 - Fix ./mach clobber --full for Python3; r?#firefox-build-system-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/091cea24ef7e
Fix ./mach clobber --full for Python3; r=firefox-build-system-reviewers,chmanchester

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/091cea24ef7e