1581393 - [protections panel] 'why' tooltip for site with protections disabled should use present, not future

Status: VERIFIED FIXED

(Firefox :: Site Identity, task, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Latest Nightly (71.0a1) and beta (70.0b6)

The 'why' tooltip in the protections panel for a site with protections disabled should use the present, not the future.

1. Load https://www.bbc.com/
2. Click on the shield in the address bar.
3. Click the blue switch to disable the privacy protections.
4. Move mouse over "Why?" in the protections panel.

Actual text:
Turning off protections will allow all trackers on this site. It may also improve some website functionality.

Expected text (suggestion):
All trackers on this site have been loaded because protections are turned off. It may also improve some website functionality.

Comment 1

[Johann Hofmann [:johannh]]

Betsy, do you have any thoughts on this?

Comment 2

[Betsy Mikel [:betsymi]]

Thanks for this catch and suggesting an edit. I don't think the second sentence is necessary in this use case.

All trackers on this site have been loaded because protections are turned off.

Comment 3

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Johann, can you help find an owner for this issue for 70 beta?

Comment 4

[Johann Hofmann [:johannh]]

This is not something we're targeting for 70. Tim, would you like to take this and update the copy for 71?

Comment 5

[Tim Huang[:timhuang]]

Sure, will do.

Comment 6

[Tim Huang[:timhuang]]

Attachment: Bug 1581393 - Changing the tooltip string of the 'why' on the protections panel if the ETP is off. r?nhnt11!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5027978b314f
Changing the tooltip string of the 'why' on the protections panel if the ETP is off. r=nhnt11,flod

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/5027978b314f

Comment 9

[Cristian Fogel [:cfogel]]

Confirmed with 71.0a1 (2019-09-15) on Windows 10.
Fix verified with 71.0b8 on Windows 10, macOS 10.13.6, Ubuntu 16.04.