1581409 - [protection panel] reports blocking of social media trackers when they are allowed and loaded

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox 71.0a1 (latest Nightly) and 70.0b6 on Windows 8.1

1. Open Firefox's Options.
2. Go to Privacy & Security.
3. Switch the Enhanced Tracking Protection settings to 'Custom'.
4. Disable all options.
5. Load https://senglehardt.com/test/trackingprotection/test_pages/social_tracking_protection.html
6. Click on the shield icon (which is not purple = nothing blocked).
   Actual result:
   Social media trackers listed under "Blocked". If that doesn't happen on first try, repeat with reloads.

Expected result:
Social media trackers listed under "Allowed":

Devtools' network monitor will report that the resources are loaded but would have been blocked with tracking protection enabled.

Comment 1

[Johann Hofmann [:johannh]]

Gary, do you have time to take a look at this?

Comment 2

[Gary Chen [:xeonchen]]

(In reply to Johann Hofmann [:johannh] from comment #1)

Gary, do you have time to take a look at this?

sure, no problem.

Comment 3

[Gary Chen [:xeonchen]]

Attachment: Bug 1581409 - isAllowing/isBlocking state of SocialTracking categories shouldn't consider enabled state. r=johannh

sync behavior of bug 1575813

Comment 4

[Gary Chen [:xeonchen]]

Attachment: Bug 1581409 - ensure `SocialTracking` enabled status is correct;

• to check the enabled status, we must have:
  • TP or ETP is enabled
  • block social tracking cookies is enabled
• sync behavior/tests from fingerprinter/cryptominer
  • check isAllowing/isBlocking without enabled status
  • add testCategoryItem()

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f94173bcd08d
ensure `SocialTracking` enabled status is correct; r=johannh

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f94173bcd08d

Comment 8

[Daniel Kolsis]

Verified - Fixed - Checked on the latest Nightly 71 on Win 10 x64, the issue can no longer be reproduced.