1581426 - Firefox Lockwise in Protection Report claims newly created Sync account connects with 1 other device, but should be 0

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox 71.0a1 from today and 70.0b6 on Windows 8.1

Firefox Lockwise in Protection Report claims newly created Sync account connects with 1 other device, but should be 0.

Steps to reproduce:

1. Click on the avatar icon in the toolbar.
2. Choose option to sign in with Firefox account.
3. Enter an email address which doesn't have a Firefox account yet (or delete it before at https://accounts.firefox.com - at your own risk).
4. Enter password and ago.
5. Pull email.
6. Verify the account with the link from the email.
7. Open about:protections
8. Scroll to the bottom.

Actual result:
Page claims there is 1 other device connected - that should not be possible because it's a new account.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Johann can you help find an owner for this one?

Comment 2

[Johann Hofmann [:johannh]]

Erica, did you want to take this?

Comment 3

[Erica Wright [:ewright]]

Yes, this is going to be fixed for 71, but I'm waiting on a string change first. The number is not actually incorrect, just the way in which it is worded. Betsy is aware and working on it.
This doesn't actually block skyline, we should perhaps remove that from the whiteboard

Comment 4

[Johann Hofmann [:johannh]]

71 is ending today. Depending on the string change we can probably still ask to get this in if we're quick now. Betsy, Erica, has there been any progress on this? :)

Thanks!

Comment 6

[Betsy Mikel [:betsymi]]

Erica and I spoke about this. Here are the string changes. A decision was made to remove Sync from the string because it adds a layer of confusion about what you're syncing to. Have cleared this with UX content team as we are removing the feature name from the string. We are OK with that because we feel this wording is actually more clear.

Thanks Erica for talking this out with me!

[ 0 ] Connected to 0 devices Turn on Sync…
[ 1 ] Connected to 1 device Manage devices…
[ 2 ] Connected to 2 devices Manage devices…

Note that we are also adding the ellipses to all cases.

Comment 7

[Erica Wright [:ewright]]

Attachment: Bug 1581426 - Update Lockwise connected devices string.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e61b2935e9d5
Update Lockwise connected devices string. r=fluent-reviewers,nhnt11,flod

Comment 9

[Cristian Brindusan [:cbrindusan]]

Backed out changeset e61b2935e9d5 (Bug 1581426) for bc failures at browser_protections_lockwise.js.

Backout: https://hg.mozilla.org/integration/autoland/rev/c162ad97808da1fb11dba53934534d1f4771f082

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=e61b2935e9d500263c9d73a5be6767499c3abb75&selectedJob=276489889

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276489889&repo=autoland&lineNumber=2010

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/320e0eac589d
Update Lockwise connected devices string. r=fluent-reviewers,nhnt11,flod

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/320e0eac589d

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.