Closed
Bug 1581514
Opened 5 years ago
Closed 5 years ago
remove grid usage from comm/mail/components/compose/content/dialogs/EdReplace.xul
Categories
(Thunderbird :: Message Compose Window, task)
Thunderbird
Message Compose Window
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 71.0
People
(Reporter: khushil324, Assigned: khushil324)
References
Details
Attachments
(1 file, 3 obsolete files)
|
3.84 KB,
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → khushil324
Blocks: tb-burn-xul-grids
|
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #9093007 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Updated•5 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9093007 [details] [diff] [review]
Bug-1581514_remove-grid-EdReplace.patch
Review of attachment 9093007 [details] [diff] [review]:
-----------------------------------------------------------------
::: mail/components/compose/content/dialogs/EdReplace.xul
@@ +37,5 @@
> + </html:div>
> + <html:div>
> + <textbox id="dialog.replaceInput" oninput="doEnabling();"/>
> + </html:div>
> + <html:div></html:div>
no empty divs please.
could you change to html input here too while you're here
Attachment #9093007 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Updated•5 years ago
|
Attachment #9093007 -
Flags: review+
|
|
Assignee | |
Comment 3•5 years ago
|
||
Attachment #9093007 -
Attachment is obsolete: true
Attachment #9093275 -
Flags: review?(mkmelin+mozilla)
|
|
||
Comment 4•5 years ago
|
||
Comment on attachment 9093275 [details] [diff] [review]
Bug-1581514_remove-grid-EdReplace.patch
Review of attachment 9093275 [details] [diff] [review]:
-----------------------------------------------------------------
::: mail/components/compose/content/dialogs/EdReplace.xul
@@ +31,5 @@
> + <label value="&findField.label;" accesskey="&findField.accesskey;" control="dialog.findInput"/>
> + </html:div>
> + <html:div>
> + <html:input id="dialog.findInput" class="input-inline-color" oninput="doEnabling();">
> + </html:input>
html:input is self-closing
input-inline-color is intended for <input type="color">
@@ +38,5 @@
> + <label value="&replaceField.label;" accesskey="&replaceField.accesskey;" control="dialog.replaceInput"/>
> + </html:div>
> + <html:div>
> + <html:input id="dialog.replaceInput" class="input-inline-color" oninput="doEnabling();">
> + </html:input>
same
@@ +40,5 @@
> + <html:div>
> + <html:input id="dialog.replaceInput" class="input-inline-color" oninput="doEnabling();">
> + </html:input>
> + </html:div>
> + <html:div style="grid-column:2/2;">
please add a class for it. grid-item-col2 perhaps
Attachment #9093275 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Comment 5•5 years ago
|
||
Attachment #9093275 -
Attachment is obsolete: true
Attachment #9093300 -
Flags: review?(mkmelin+mozilla)
|
|
||
Comment 6•5 years ago
|
||
Comment on attachment 9093300 [details] [diff] [review]
Bug-1581514_remove-grid-EdReplace.patch
Review of attachment 9093300 [details] [diff] [review]:
-----------------------------------------------------------------
::: mail/themes/shared/mail/grid-layout.css
@@ +39,5 @@
> grid-column: 1 / -1;
> }
> +
> +.grid-item-col2 {
> + grid-column:2/2;
nit: space after:
Attachment #9093300 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Assignee | |
Comment 7•5 years ago
|
||
Attachment #9093300 -
Attachment is obsolete: true
Attachment #9093565 -
Flags: review+
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e569c75379ef
remove grid usage from EdReplace.xul. r=mkmelin
|
||
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 71.0
You need to log in
before you can comment on or make changes to this bug.
Description
•