Closed Bug 1581534 Opened 5 months ago Closed 5 months ago

remove grid usage from comm/mail/components/compose/content/dialogs/EdTableProps.xul

Categories

(Thunderbird :: Message Compose Window, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: khushil324, Assigned: khushil324)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 4 obsolete files)

No description provided.
Assignee: nobody → khushil324
Attachment #9093038 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Comment on attachment 9093038 [details] [diff] [review]
Bug-1581534_remove-grid-EdTableProps.patch

Review of attachment 9093038 [details] [diff] [review]:
-----------------------------------------------------------------

This dialog is such a mess... (to start with)

::: mail/components/compose/content/dialogs/EdTableProps.xul
@@ +51,5 @@
> +            <html:div>
> +              <textbox class="narrow" id="TableRowsInput" oninput="forceInteger(this.id);"/>
> +            </html:div>
> +            <html:div>
> +              <spring class="bigspacer"/>

we shouldn't need to use <spring>.
Attachment #9093038 - Attachment is obsolete: true
Attachment #9093038 - Flags: review?(mkmelin+mozilla)
Attachment #9093270 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9093270 [details] [diff] [review]
Bug-1581534_remove-grid-EdTableProps.patch

Review of attachment 9093270 [details] [diff] [review]:
-----------------------------------------------------------------

The 3 "pixels" dropdowns are misaligned.

But, I think this whole dialog is extremely confusing. What you really have is 

Selection

----
Size table, Content Alignment table.

... and a bunch of things unrelated in any way. 

You don't really have a 6 column grid. It's 2 or 3 columns. You may want to have several sections.
Attachment #9093270 - Flags: review?(mkmelin+mozilla) → review-

(In reply to Magnus Melin [:mkmelin] from comment #4)

The 3 "pixels" dropdowns are misaligned.

Which dropdowns are you talking about? Can you share a screen shot?

The ones with where you choose size. (pixels or % of window)

Attachment #9093270 - Attachment is obsolete: true
Attachment #9094172 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9094172 [details] [diff] [review]
Bug-1581534_remove-grid-EdTableProps.patch

Review of attachment 9094172 [details] [diff] [review]:
-----------------------------------------------------------------

The size dropdown is still not correctly aligned. Will attach a screenshot.

BTW, what about the Cells tab?
Attachment #9094172 - Flags: review?(mkmelin+mozilla) → review-
Attached image tp2.png

(In reply to Magnus Melin [:mkmelin] from comment #8)

BTW, what about the Cells tab?

Do you want to remove stuff from there?

No. Nevermind.

Attachment #9094172 - Attachment is obsolete: true
Attachment #9094385 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9094385 [details] [diff] [review]
Bug-1581534_remove-grid-EdTableProps.patch

Review of attachment 9094385 [details] [diff] [review]:
-----------------------------------------------------------------

In the cells tab, the dropdowns for size are still misaligned
Size in the table tab is now ok
Attachment #9094385 - Flags: review?(mkmelin+mozilla) → review-
Attachment #9094385 - Attachment is obsolete: true
Attachment #9094526 - Flags: review?(mkmelin+mozilla)
Attachment #9094526 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/083cbc1535b2
remove grid usage from EdTableProps.xul. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
You need to log in before you can comment on or make changes to this bug.