1581569 - Experiment adding TypeScript support to the new performance client

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), task, P3)

Description

[Greg Tatum [:gregtatum] (REO Fx132)]

We have the new infrastructure to run node scripts in CI, with mocha and jest. We could hook up some CI to configure devtools code to run TypeScript checks using JS Docs. This gets us full type checking, with minimal code changes, and no build step.

Comment 1

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1581569 - Replace recording state object with plain strings; r?julienw

This patch changes the use of the recording state object with raw strings.
The strings can be type checked, and there is no more benefit to having
it as an Object. The plain strings are easier to type check.

Comment 2

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1581569 - Configure the performance client to use TypeScript; r?julienw,jlast

This commit sets up the configuration for TypeScript to work in tree.
It also adds the commands to run everything in our CI. For now this
configuration is limiting everything to the performance-new directory
as much as possible.

Depends on D46040

Comment 3

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1581569 - Add type definitions for performance-new client; r?julienw,jlast

Everything should be typed in the JS Docs. I added a bunch of TODOs for features
the could be added in the future, but weren't valuable for this initial
prototype. Unfortunately I couldn't get the @types folder working, and had to
co-locate the redux.d.ts next to the vender file. TypeScript was attempting
to parse the file, and was failing.

Depends on D46041

Comment 4

[Greg Tatum [:gregtatum] (REO Fx132)]

Here is a failing example on treeherder: https://treeherder.mozilla.org/#/jobs?repo=try&revision=201f27967c8c6f26c6a4430fb1307478769762f7&searchStr=devtools

Comment 5

[Greg Tatum [:gregtatum] (REO Fx132)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=529ac953065bf6d92a1985bf971b73acb124cb6c

Comment 6

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1586757 - Rename .jsm files to .jsm.js to allow type checking; r?julienw

Depends on D46042

Comment 7

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1586757 - Create a @types directory and change to // @ts-check; r?julienw

Depends on D47911

Comment 8

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1586757 - Add types to everything but the components; r?julienw

Depends on D47912

Comment 9

[Greg Tatum [:gregtatum] (REO Fx132)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d85f16d097f6aa9bed1f48a49f2272084c4d9fd

Comment 10

[Phabricator Automation]

Comment on attachment 9098253 [details]
Bug 1586757 - Rename .jsm files to .jsm.js to allow type checking; r?julienw

Revision D47911 was moved to bug 1586757. Setting attachment 9098253 [details] to obsolete.

Comment 11

[Phabricator Automation]

Comment on attachment 9098254 [details]
Bug 1586757 - Create a @types directory and change to // @ts-check; r?julienw

Revision D47912 was moved to bug 1586757. Setting attachment 9098254 [details] to obsolete.

Comment 12

[Phabricator Automation]

Comment on attachment 9098255 [details]
Bug 1586757 - Add types to everything but the components; r?julienw

Revision D47913 was moved to bug 1586757. Setting attachment 9098255 [details] to obsolete.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/907946837998
Replace recording state object with plain strings; r=julienw
https://hg.mozilla.org/integration/autoland/rev/2c1c4849c8c9
Configure the performance client to use TypeScript; r=julienw
https://hg.mozilla.org/integration/autoland/rev/1dd081553a3a
Add type definitions for performance-new client; r=julienw

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/907946837998
https://hg.mozilla.org/mozilla-central/rev/2c1c4849c8c9
https://hg.mozilla.org/mozilla-central/rev/1dd081553a3a