Intermittent svg/blend-exclusion.svg == svg/blend-exclusion-ref.svg | image comparison, max difference: 5, number of differing pixels: 254
Categories
(Core :: Graphics: WebRender, defect, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox76 | --- | unaffected |
| firefox77 | --- | unaffected |
| firefox78 | --- | fixed |
| firefox79 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: longsonr)
References
(Regression)
Details
(Keywords: intermittent-failure, regression, Whiteboard: [retriggered])
Attachments
(1 file)
Filed by: cbrindusan [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=266890604&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/BkImyqLUSVSJH51Tv8Yb9A/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/BkImyqLUSVSJH51Tv8Yb9A/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
[task 2019-09-16T18:45:01.306Z] 18:45:01 INFO - REFTEST TEST-START | http://10.7.205.219:8854/tests/layout/reftests/svg/blend-exclusion.svg == http://10.7.205.219:8854/tests/layout/reftests/svg/blend-exclusion-ref.svg
[task 2019-09-16T18:45:01.512Z] 18:45:01 INFO - REFTEST TEST-LOAD | http://10.7.205.219:8854/tests/layout/reftests/svg/blend-exclusion.svg | 1384 / 1925 (71%)
[task 2019-09-16T18:45:01.512Z] 18:45:01 INFO - REFTEST TEST-LOAD | http://10.7.205.219:8854/tests/layout/reftests/svg/blend-exclusion-ref.svg | 1384 / 1925 (71%)
[task 2019-09-16T18:45:01.512Z] 18:45:01 INFO - REFTEST INFO | REFTEST fuzzy test (0, 0) <= (5, 254) <= (4, 254)
[task 2019-09-16T18:45:01.512Z] 18:45:01 INFO - REFTEST TEST-UNEXPECTED-FAIL | http://10.7.205.219:8854/tests/layout/reftests/svg/blend-exclusion.svg == http://10.7.205.219:8854/tests/layout/reftests/svg/blend-exclusion-ref.svg | image comparison, max difference: 5, number of differing pixels: 254
|
||
Updated•5 years ago
|
| Comment hidden (Intermittent Failures Robot) |
|
||
Comment 2•5 years ago
|
||
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.
|
||
Comment 3•4 years ago
|
||
Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294103905&repo=autoland&lineNumber=7221
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
|
|
||
Comment 6•4 years ago
|
||
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.
|
||
Comment 7•4 years ago
|
||
Recent log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303921037&repo=autoland&lineNumber=9659
|
||
Comment 8•4 years ago
|
||
It seems that is started to fail from https://hg.mozilla.org/integration/autoland/rev/9734a05d25053a0c6510606980c1aeb3cdb3aadc
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304341143&repo=autoland&lineNumber=9680
Robert, can you please take a look?
|
Assignee | |
Comment 9•4 years ago
•
|
||
I can't see how that change could have any effect at all. It only applies to elements that have an autofocus attribute. On top of that, this was reported 9 months ago and my fix landed 7 days ago.
|
|
Assignee | |
Comment 10•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 11•4 years ago
|
||
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 12•4 years ago
|
||
|
|
||
Comment 13•4 years ago
|
||
Robert,
I believe Cristina was talking about the recent spike of failures that was caused by your changes.
|
|
Assignee | |
Comment 14•4 years ago
|
||
Nevertheless a change to the code along the lines of if (element has an autofocus attribute) { do something } cannot possibly affect a testcase that doesn't have an autofocus attribute.
| Comment hidden (Intermittent Failures Robot) |
|
|
||
Comment 16•4 years ago
|
||
(In reply to Robert Longson [:longsonr] from comment #14)
Nevertheless a change to the code along the lines of if (element has an autofocus attribute) { do something } cannot possibly affect a testcase that doesn't have an autofocus attribute.
For the record: from looking at the retrigger results, I agree with the sheriffs that your commit is where this started spiking. But -- I would bet the "culprit" wasn't your code-changes, but rather the fact that you added some reftests.
Any new reftests cause reftest rebucketing, which can cause fuzzy issues to crop up in different tests (or to manifest in different ways). I don't know the exact mechanism, but it has felt like "the first test to use feature $X is susceptible to having a fuzzy pixel or two", or something to that effect. So, test-rebucketing events (caused by new reftests being added) can subtly change reftest renderings.
|
|
||
Comment 17•4 years ago
•
|
||
(Fortunately this doesn't happen every time we add a new reftest, but it does happen & it seems to be the best explanation for the facts.)
|
||
Comment 18•4 years ago
|
||
Pushed by longsonr@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f3a829091fef Make blend-exclusion reftest a slightly fuzzier match on geckoview webrender r=dholbert
|
|
Assignee | |
Comment 19•4 years ago
|
||
Nice try on the explanation Daniel, but it wouldn't cover what happened in bug 1642168. There I'm supposed to have caused 3 reftests to fail and all I did to do that was make a different reftest that was already fuzzy, slightly fuzzier. No tests added or removed and no code changed. I'm hoping the whack-a-mole game is now over.
|
|
||
Comment 20•4 years ago
|
||
Indeed, that one seems more mysterious. Thanks for addressing both of them, in any case!
|
||
Comment 21•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
|
|
||
Comment 22•4 years ago
|
||
| bugherder uplift | ||
| Comment hidden (Intermittent Failures Robot) |
|
|
||
Updated•2 years ago
|
Description
•