1581684 - Make `mach mach completion <command>` use the right Python

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect, P1)

Description

[Kris Maglione [:kmag]]

+++ This bug was initially created as a clone of Bug #1577501 +++

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1581684: Make sure ./mach mach-completion <command> uses the correct Python. r=glandium

Comment 2

[Matthew N. [:MattN]]

This is super annoying as it causes tab-completion to munge my existing input.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/311a7c41e9da
Make sure ./mach mach-completion <command> uses the correct Python. r=ahal

Comment 5

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1581684 - Fix `mach mach-completion mach -flag <command>` for python 2 commands.

This solves an edge case where tab completing a Python 2 command with global
arguments was using the wrong Python version.

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/311a7c41e9da

Comment 7

[Matthew N. [:MattN]]

Looks like this regressed again in the last few days. Rough regression range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1d96f4423d16&tochange=6c6c67870c37

Comment 8

[Mike Hommey [:glandium]]

Andrew, can you update the second patch and land it?

Comment 9

[Andrew Halberstadt [:ahal]]

Sure I'll try and get it landed soon, though looks like Matt isn't hitting the edge case, this is broken for everything. Running python2 mach mach-completion task results in this traceback:

AttributeError: 'functools.partial' object has no attribute '__name__'

  File "/home/ahal/dev/mozilla-central/python/mach/mach/commands/commandinfo.py", line 62, in completion
    all_commands = sorted(self.command_keys)
  File "/home/ahal/dev/mozilla-central/python/mach/mach/commands/commandinfo.py", line 26, in <genexpr>
    if not v.conditions or v.conditions[0].__name__ != 'REMOVED')

So looks like a regression from https://phabricator.services.mozilla.com/D67342.

Tarek, did you have a WIP somewhere to stop using functools in the conditions function? Though we probably shouldn't be relying on conditions[0].__name__ in commandinfo.py anyway.

Comment 10

[Andrew Halberstadt [:ahal]]

Yeah nvm, I'll just fix this here. Have a working patch, will attempt to add a test as well.

Comment 11

[Tarek Ziadé (:tarek)]

Ah ok, thanks, I did add Bug 1626942 if you want to close it after you're done

Comment 12

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1581684 - [mach] Fix regression to mach command completion, r?glandium

Not all callables have a name attribute.

Comment 13

[Andrew Halberstadt [:ahal]]

(In reply to Mike Hommey [:glandium] from comment #8)

Andrew, can you update the second patch and land it?

Unfortunately I still don't see a good way of implementing your comment, see my reply for more details. It's very possible I'm missing something obvious, but it's been taking up more time than I have to spend.

Comment 14

[Mike Hommey [:glandium]]

Attachment: Bug 1581684 - Fix `mach mach-completion mach -flag <command>` for python 2 commands.

This solves an edge case where tab completing a Python 2 command with global
arguments was using the wrong Python version.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84c16bc42776
[mach] Fix regression to mach command completion, r=glandium

Comment 16

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/84c16bc42776

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef38e7c833c7
Fix `mach mach-completion mach -flag <command>` for python 2 commands. r=ahal

Comment 18

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/ef38e7c833c7

Comment 19

[Matthew N. [:MattN]]

Should this bug be resolved now or was this still just a temporary solution?

Comment 20

[Andrew Halberstadt [:ahal]]

Thanks, everything should be fixed now.