1581725 - remove grid usage from comm/mail/components/preferences/connection.xul

Status: RESOLVED FIXED

(Thunderbird :: Preferences, task)

Comment 2

[Khushil Mistry [:khushil324]]

Attachment: Bug-1581725_remove-grid_connection.patch

Apply after patch from Bug 1583725.

Comment 3

[Jorg K (CEST = GMT+2)]

I'm sure you saw: https://hg.mozilla.org/mozilla-central/rev/3a4012655a64037ce150dadaf10e6a77059f2c9e#l2.1

Comment 4

[Khushil Mistry [:khushil324]]

Yeah, now I am waiting for the review from Magnus.

Comment 5

[Jorg K (CEST = GMT+2)]

This is the last de-grid bug, what's the hold up?

Comment 6

[Magnus Melin [:mkmelin]]

Intertwined with Fluent, which we want to sort out first.

Comment 7

[Magnus Melin [:mkmelin]]

See also bug 1630084 which we may want to port at the same time.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9095163 [details] [diff] [review]
Bug-1581725_remove-grid_connection.patch

Review of attachment 9095163 [details] [diff] [review]:
-----------------------------------------------------------------

Can you update this and bug 1583725 so it applies to trunk. (And sync up with bug 1630084)

Comment 9

[Tim Nguyen :ntim]

Attachment: Bug 1581725 - Remove grid usage from comm/mail/components/preferences/connection.xhtml

Comment 10

[Richard Marti (:Paenglab)]

Attachment: 1581725-de-grid-connection.diff

I added some code from m-c to resize the dialog when in DoH the Custom menuitem is selected.

Comment 11

[Magnus Melin [:mkmelin]]

Comment on attachment 9142767 [details] [diff] [review]
1581725-de-grid-connection.diff

Review of attachment 9142767 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - Thanks Tim, thanks Richard! r=mkmelin

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8f4003786ce8
Remove grid usage from comm/mail/components/preferences/connection.xhtml. r=mkmelin