1581748 - [Wayland] Overlapping areas are not painted sometime

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Where there are screen updates which overlaps - whole window update and then partial screen update - only the partial screen update is painted when Wayland buffer is not available and the painting is cached.

It's because we set fullscreen damage flag at ::Lock() according to actual screen damage thus fullscreen damage from former ::Lock() calls is lost.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1581748 - [Wayland] Fixed rendering of overlapping areas, r=jhorak

• Don't store whole buffer update information at mWholeWindowBufferDamage but use damage region instead.
• Check and remove overlapped images when they are stored at image cache.
• Remove CanDrawToWaylandBufferDirectly() as it's not very useful.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f8b2c9c8bef
[Wayland] Fixed rendering of overlapping areas, r=jhorak

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9f8b2c9c8bef

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9093258 [details]
Bug 1581748 - [Wayland] Fixed rendering of overlapping areas, r=jhorak

Beta/Release Uplift Approval Request

• User impact if declined: Overlapping areas may not be rendered correctly on Wayland.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1580152
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Linux/Wayland only.
• String changes made/needed: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9093258 [details]
Bug 1581748 - [Wayland] Fixed rendering of overlapping areas, r=jhorak

Wayland fix, approved for 70.0b8.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/45c0e8a9df93