1581757 - Support slicing the scene into an arbitrary number of picture cache slices

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 1581757 - Support slicing the scene into an arbitrary number of picture cache slices

Previously, the setup_picture_caching function was hard coded
to support only a very specific shape of display list. With this
change, flags are added to PrimitiveCluster that can specify
if a picture cache slice should be created before / after this
cluster when picture caching is set up.

The usage of these flags in this patch matches the old behaviour,
so should not have any functional effect.

However, in future we will make use of this functionality to
create picture slices for a number of different use cases, such as:

• Creating cache tiles for the UI.
• Slicing the scene where there are video elements, in order to
  allow these to be composited directly by the OS. This may also
  apply to WebGL and/or canvas elements.
• Slicing the scene when there is a very large fixed position
  background image or other element, to avoid invalidating the
  entire tile cache each frame.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08f2148de713
Support slicing the scene into an arbitrary number of picture cache slices r=nical

Comment 3

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=os%2Cx%2C10.14%2Cquantumrender%2Cdebug%2Creftests%2Ctest-macosx1014-64-qr%2Fdebug-reftest-e10s-3%2Cr%28r3%29&fromchange=fa579e9b1e7dc010ff707dd6eae15fef44253f0e&tochange=ce2f8a6c77c6c3179d335144901636b0cf91b771&selectedJob=267381935

https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=Android%2C8.0%2CPixel2%2CQuantumRender%2Copt%2CReftests%2Ctest-android-hw-p2-8-0-arm7-api-16-qr%2Fopt-geckoview-reftest-e10s-2%2CR%28R2%29&fromchange=fa579e9b1e7dc010ff707dd6eae15fef44253f0e&tochange=ce2f8a6c77c6c3179d335144901636b0cf91b771&selectedJob=267379030

Failure logs: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=267381935&repo=autoland&lineNumber=69441
https://treeherder.mozilla.org/logviewer.html#?job_id=267385459&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/089574291109a1f580930e4a00ef8189eb998b78

Comment 4

[Glenn Watson [:gw]]

The android HW tests look like genuine new PASS results.

The OSX ones are a bit trickier to know - since it looks like there are some intermittents on some of those tests at the moment.

I'll do some investigation locally and try to re-land this tomorrow.

Comment 5

[Glenn Watson [:gw]]

Rebased the patch, and filed https://bugzilla.mozilla.org/show_bug.cgi?id=1583091 to track the mac + scrollbar issue, which was previously only intermittent https://bugzilla.mozilla.org/show_bug.cgi?id=1581878.

I'll do one more try run on all platforms before pushing this.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2c9dbf826fe
Support slicing the scene into an arbitrary number of picture cache slices r=nical,kvark

Comment 7

[Dorel Luca [:dluca]]

Backed out changeset c2c9dbf826fe (bug 1581757) by dev's request

Push that was backed out
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=c2c9dbf826fe7b81bc8535988d2a48570a43c7e3

Backout:
https://hg.mozilla.org/mozilla-central/rev/1dc1a755079a15e35cb234db511e52ab463b2f42

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc39374e708f
Support slicing the scene into an arbitrary number of picture cache slices r=nical,kvark

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/fc39374e708f