1581773 - [Wayland] Bookmark popup panel disappears when opening a dropdown

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Kestrel]

Attachment: Floating dropdown after parent popup disappears

STR:

1. Click the bookmark star in the location bar.
2. In the bookmark popup panel, click the Folder dropdown.

Expected:

The dropdown appears over the parent popup.

Actual:

The parent popup disappears and the dropdown is left floating on its own. Dropdowns in extension popups are similarly affected.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=60ba89028ca86c6fddfb59009f99ccd21167f41e&tochange=a7980614bc3c528727f1b55e111654e708f1c3df

Regressed by Bug 1567434.

Comment 1

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Thanks, this should be fixed by Bug 1580174 - can you try that on latest nightly?

Comment 2

[Kestrel]

The Bug 1580174 test case permission notification dropdowns work for me on latest 2019-09-16 Nightly (parent notification popup remains visible) but the bookmark popup dropdowns still have this issue.

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Jan, I guess we need to expand our exception list on Wayland, correct?

Comment 4

[Jan Horak [:jhorak]]

(In reply to Martin Stránský [:stransky] from comment #3)

Jan, I guess we need to expand our exception list on Wayland, correct?
Yes, we do.

Comment 5

[Jan Horak [:jhorak]]

Attachment: Bug 1581773 - Fix disappearing bookmark edit panel when choosing folder under Wayland; r=stransky

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/847db8b778d8
Fix disappearing bookmark edit panel when choosing folder under Wayland; r=stransky

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/847db8b778d8

Comment 8

[Kestrel]

This has not fixed the extension popup case (Bug 1583035).

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Does this need a Beta approval request?

Comment 10

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Comment on attachment 9093850 [details]
Bug 1581773 - Fix disappearing bookmark edit panel when choosing folder under Wayland; r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: Missing bookmark panel on Linux/Wayland.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Linux/Wayland only.
• String changes made/needed:

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9093850 [details]
Bug 1581773 - Fix disappearing bookmark edit panel when choosing folder under Wayland; r=stransky

Fix for Wayland issue, low risk, let's take this for beta 11.

Comment 12

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/97f7c310e247