Closed Bug 1581814 Opened 2 years ago Closed 2 years ago

Re-enable mobile/android/components/extensions/test/mochitest/test_ext_tabs_executeScript_bad.html

Categories

(WebExtensions :: Android, task, P3)

task

Tracking

(firefox75 fixed)

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: robwu, Assigned: championshuttler, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file, 1 obsolete file)

I just ran the test locally, and it completed successfully without errors.

To resolve this bug, simply remove https://searchfox.org/mozilla-central/rev/7ed8e2d3d1d7a1464ba42763a33fd2e60efcaedc/mobile/android/components/extensions/test/mochitest/mochitest.ini#27

The fix is easy, so this is a very good candidate for people who want to get familiar with contributing to extension code on Android.

To get started, see https://wiki.mozilla.org/WebExtensions/Contribution_Onramp

Then start the Android emulator with ./mach android-emulator

To check whether the patch works, run the following command (don't forget to set the MOZCONFIG environment variable if needed):

./mach mochitest mobile/android/components/extensions/test/mochitest/

Without a fix, the output will be:

 4:27.28 TEST_START: mobile/android/components/extensions/test/mochitest/test_ext_tabs_executeScript_bad.html
 4:27.28 TEST_END: SKIP

When the test is re-enabled, the test should run to completion.

Mentor: rob
Keywords: good-first-bug
Priority: -- → P3

Hi,
Can I solve this if it's still open
Thanks

Flags: needinfo?(rob)

Hi Harsh, this issue is still open.

You have to set up a development environment to run the test in an Android emulator, and confirm that the test passes after fixing the bug. See comment 1 for more details.

Flags: needinfo?(rob)

Hello Rob :)
Could I ask you about android build?
I want to build android and run command (i.e, ./mach android-emulator).
Should I refer this page(Build Using Android Studio section)[0] for solving what I want?

[0]
https://mozilla.github.io/geckoview/contributor/geckoview-quick-start

Flags: needinfo?(rob)

The reason why I ask this is because there is an up-to-date issue in the document and an error occurs when I follow the manual.

When performing the following manuals:
If the gradle sync does not automatically start, select File > Sync Project with Gradle Files.

The following error occurs:
ERROR: Building with Gradle is only supported for Fennec, i.e., MOZ_BUILD_APP == 'mobile/android'.

I have never tried to build with Android studio, only the command line, like this:

./mach bootstrap
./mach build

Are you running into problems when you try to build Android? If so, please file a new bug in the "Firefox Build System" product, specifically the "Android Studio and Gradle integration" component. Here is the list of open bugs. If you prefer to chat (outside of Bugzilla), join us in the #addons room at chat.mozilla.org.

Flags: needinfo?(rob)
Assignee: nobody → aroraharsh010
Status: NEW → ASSIGNED
Assignee: aroraharsh010 → shivams2799
Pushed by shivams2799@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d2b292c1241c
Re-enable mobile/android/components/extensions/test/mochitest/test_ext_tabs_executeScript_bad.html.r=robwu
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
Attachment #9127133 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.