Closed Bug 1581862 Opened 5 years ago Closed 4 years ago

Intermittent dom/tests/browser/browser_windowProxy_transplant.js | chromeWin1x should be a dead wrapper after navigation - false == true -

Categories

(Core :: DOM: Window and Location, defect, P3)

Product:
Core
Component:
DOM: Window and Location
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- wontfix
firefox73 --- wontfix
firefox74 --- wontfix

People

(Reporter: intermittent-bug-filer, Assigned: mccr8)

References

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1581862 - Updated disable for browser_windowProxy_transplant.js on macosx when Fission is not enabled. r=#intermittent-reviewers
47 bytes, text/x-phabricator-request
Details | Review

Filed by: rgurzau [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=267026299&repo=try
Full log: https://queue.taskcluster.net/v1/task/Obx77UDURWi4n7adNkEWOg/runs/0/artifacts/public/logs/live_backing.log

task 2019-09-17T12:26:25.926Z] 12:26:25 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | win0 shouldn't be a dead wrapper before navigation - true == true -
[task 2019-09-17T12:26:25.927Z] 12:26:25 INFO - Got an iframe load event!
[task 2019-09-17T12:26:25.927Z] 12:26:25 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | waiving xrays creates a new thing? - true == true -
[task 2019-09-17T12:26:25.927Z] 12:26:25 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | same to same-origin BrowsingContext match - {} == {} -
[task 2019-09-17T12:26:25.927Z] 12:26:25 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | same to same-origin WindowProxy match - [object Window] == [object Window] -
[task 2019-09-17T12:26:25.927Z] 12:26:25 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | win1 shouldn't be a dead wrapper before navigation - true == true -
[task 2019-09-17T12:26:25.928Z] 12:26:25 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | chromeWin1 shouldn't be a dead wrapper before navigation - true == true -
[task 2019-09-17T12:26:25.928Z] 12:26:25 INFO - Chrome script asking for load of http://example.com/browser/dom/tests/browser/file_postMessage_parent.html
[task 2019-09-17T12:26:25.928Z] 12:26:25 INFO - Chrome script done calling PostMessage
[task 2019-09-17T12:26:25.929Z] 12:26:25 INFO - Console message: [JavaScript Warning: "window.controllers/Controllers is deprecated. Do not use it for UA detection." {file: "http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html" line: 0}]
[task 2019-09-17T12:26:25.929Z] 12:26:25 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.com/browser/dom/tests/browser/file_postMessage_parent.html" line: 0}]
[task 2019-09-17T12:26:25.929Z] 12:26:25 INFO - Got an iframe load event!
[task 2019-09-17T12:26:25.930Z] 12:26:25 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | . Should get a remote outer window proxy when accessing old window proxy -
[task 2019-09-17T12:26:25.930Z] 12:26:25 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | . Should get a remote outer window proxy when accessing new window proxy -
[task 2019-09-17T12:26:25.930Z] 12:26:25 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | win1 shouldn't be a dead wrapper after navigation - true == true -
[task 2019-09-17T12:26:25.931Z] 12:26:25 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | chromeWin1 shouldn't be a dead wrapper after navigation - true == true -
[task 2019-09-17T12:26:25.931Z] 12:26:25 INFO - Buffered messages finished
[task 2019-09-17T12:26:25.931Z] 12:26:25 INFO - TEST-UNEXPECTED-FAIL | dom/tests/browser/browser_windowProxy_transplant.js | chromeWin1x should be a dead wrapper after navigation - false == true -
[task 2019-09-17T12:26:25.931Z] 12:26:25 INFO - Stack trace:
[task 2019-09-17T12:26:25.931Z] 12:26:25 INFO - resource://testing-common/content-task.js line 62 > eval:null:116
[task 2019-09-17T12:26:25.931Z] 12:26:25 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-09-17T12:26:25.932Z] 12:26:25 INFO - TEST-UNEXPECTED-FAIL | dom/tests/browser/browser_windowProxy_transplant.js | content.win1x should be a dead wrapper after navigation - false == true -
[task 2019-09-17T12:26:25.932Z] 12:26:25 INFO - Stack trace:
[task 2019-09-17T12:26:25.932Z] 12:26:25 INFO - resource://testing-common/content-task.js line 62 > eval:null:120
[task 2019-09-17T12:26:25.932Z] 12:26:25 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | same to cross-origin navigation BrowsingContext match - {} == {} -
[task 2019-09-17T12:26:25.932Z] 12:26:25 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | same to cross-origin navigation WindowProxy match - [object Object] == [object Object] -
[task 2019-09-17T12:26:25.932Z] 12:26:25 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | win1 shouldn't be a dead wrapper after navigation - true == true -
[task 2019-09-17T12:26:25.932Z] 12:26:25 INFO - Chrome script asking for load of http://example.org/browser/dom/tests/browser/file_postMessage_parent.html
[task 2019-09-17T12:26:25.932Z] 12:26:25 INFO - Chrome script done calling PostMessage
[task 2019-09-17T12:26:25.933Z] 12:26:25 INFO - GECKO(2018) | Content got event http://example.com/browser/dom/tests/browser/file_postMessage_parent.html {"action":"navigate","location":"http://example.org/browser/dom/tests/browser/file_postMessage_parent.html"}
[task 2019-09-17T12:26:26.032Z] 12:26:26 INFO - GECKO(2018) | Content running top level script http://example.org/browser/dom/tests/browser/file_postMessage_parent.html
[task 2019-09-17T12:26:26.072Z] 12:26:26 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.org/browser/dom/tests/browser/file_postMessage_parent.html" line: 0}]
[task 2019-09-17T12:26:26.072Z] 12:26:26 INFO - GECKO(2018) | Content got load of http://example.org/browser/dom/tests/browser/file_postMessage_parent.html
[task 2019-09-17T12:26:26.073Z] 12:26:26 INFO - GECKO(2018) | Content got event http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html {"event":"load","location":"http://example.org/browser/dom/tests/browser/file_postMessage_parent.html"}
[task 2019-09-17T12:26:26.073Z] 12:26:26 INFO - Got an iframe load event!

Component: DOM: Core & HTML → DOM: Content Processes

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jmathies)
Flags: needinfo?(jmathies)
Priority: -- → P3

In the last 7 days, there have been 22 failures on:

  • opt: macosx1014-64-shippable, linux64-shippable, linux64
  • asan: linux64

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279496153&repo=autoland&lineNumber=7551

This is an intermittent failing test on the ubuntu1804 image as it is in-tree.

It did pass if compiz is installed in the test image, but given that compiz is not installed by default on ubuntu1804 and wanting to ensure that we test in the closest possible environment for end users, this bug needs attention.

Knowing that having only the window manager (which removes the top bar, dock, and other elements of a full desktop environment) should help with the fixing of this test. The expected migration date to ubuntu1804 is end of December.

Andrew - Nika has her needinfos blocked; would you be able to take a look at this failure, or pass on the ni to someone else who may know about this test? I suspect it is the presence of additional UI elements from the full desktop environment which is interfering with the test somehow.

Flags: needinfo?(continuation)

(In reply to Edwin Takahashi (:egao, :etakahashi) from comment #17)

Knowing that having only the window manager (which removes the top bar, dock, and other elements of a full desktop environment) should help with the fixing of this test. The expected migration date to ubuntu1804 is end of December.

This test doesn't have anything to do with the UI. Maybe the timing is changed somehow.

Andrew - Nika has her needinfos blocked; would you be able to take a look at this failure, or pass on the ni to someone else who may know about this test? I suspect it is the presence of additional UI elements from the full desktop environment which is interfering with the test somehow.

I could take a look. I don't understand what the problem you are trying to solve is. Is the intermittent failure rate a lot higher than what it is right now, to the point where it would cause problems? Do you have a link to a failure log? How can I run the test this way locally and on try?

Flags: needinfo?(continuation) → needinfo?(egao)

It looks like content.win1x is also failing to be a dead wrapper. It looks like the failure rate might be higher in verify mode, so that would be something to try: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279287397&repo=mozilla-central&lineNumber=4955

Assignee: nobody → continuation
Component: DOM: Content Processes → DOM: Core & HTML

(In reply to Andrew McCreight [:mccr8] from comment #18)

(In reply to Edwin Takahashi (:egao, :etakahashi) from comment #17)

Knowing that having only the window manager (which removes the top bar, dock, and other elements of a full desktop environment) should help with the fixing of this test. The expected migration date to ubuntu1804 is end of December.

This test doesn't have anything to do with the UI. Maybe the timing is changed somehow.

The part I neglected to mention was that ubuntu1804 appears to have more async-iness in the window move/resize than previous releases. I strongly suspect it's due to GNOME desktop environment being the case.

I could take a look. I don't understand what the problem you are trying to solve is. Is the intermittent failure rate a lot higher than what it is right now, to the point where it would cause problems? Do you have a link to a failure log? How can I run the test this way locally and on try?

Initially (when I submitted the comment) it appeared that this failure was consistent and permanent on ubuntu1804, but now it looks rather intermittent at a fairly low rate, so perhaps it isn't something that warrants immediate attention (though it would be nice).

The ubuntu1804 docker image is in-tree and can be used by specifying ./mach try fuzzy --ubuntu-bionic and selecting the test-linux64 jobs as normal. The --ubuntu-bionic flag will replace usage of default 1604 test image with 1804.

Flags: needinfo?(egao)
Assignee: continuation → nobody

There are 26 total failures in the last 7 days on macosx1014-64-shippable opt mostly and few on linux64-shippable and linux64 opt builds.

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283399231&repo=autoland&lineNumber=8684

[task 2020-01-03T22:40:10.729Z] 22:40:10 INFO - TEST-START | dom/tests/browser/browser_windowProxy_transplant.js
[task 2020-01-03T22:40:11.411Z] 22:40:11 INFO - GECKO(3277) | Content running top level script http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html
[task 2020-01-03T22:40:11.445Z] 22:40:11 INFO - GECKO(3277) | Content got load of http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html
[task 2020-01-03T22:40:11.445Z] 22:40:11 INFO - GECKO(3277) | Content got event http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html {"event":"load","location":"http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html"}
[task 2020-01-03T22:40:11.501Z] 22:40:11 INFO - GECKO(3277) | Content running top level script http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html
[task 2020-01-03T22:40:11.501Z] 22:40:11 INFO - GECKO(3277) | Content got load of http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html
[task 2020-01-03T22:40:11.536Z] 22:40:11 INFO - GECKO(3277) | Content got event http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html {"event":"load","location":"http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html"}
[task 2020-01-03T22:40:11.536Z] 22:40:11 INFO - GECKO(3277) | Content got event http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html {"action":"navigate","location":"http://example.com/browser/dom/tests/browser/file_postMessage_parent.html"}
[task 2020-01-03T22:40:11.845Z] 22:40:11 INFO - GECKO(3277) | Content running top level script http://example.com/browser/dom/tests/browser/file_postMessage_parent.html
[task 2020-01-03T22:40:11.939Z] 22:40:11 INFO - GECKO(3277) | Content got load of http://example.com/browser/dom/tests/browser/file_postMessage_parent.html
[task 2020-01-03T22:40:11.985Z] 22:40:11 INFO - TEST-INFO | started process screencapture
[task 2020-01-03T22:40:12.141Z] 22:40:12 INFO - TEST-INFO | screencapture: exit 0
[task 2020-01-03T22:40:12.141Z] 22:40:12 INFO - Buffered messages logged at 22:40:10
[task 2020-01-03T22:40:12.142Z] 22:40:12 INFO - Entering test bound
[task 2020-01-03T22:40:12.142Z] 22:40:12 INFO - Console message: OpenGL compositor Initialized Succesfully.
[task 2020-01-03T22:40:12.142Z] 22:40:12 INFO - Version: 2.1 INTEL-12.9.22
[task 2020-01-03T22:40:12.142Z] 22:40:12 INFO - Vendor: Intel Inc.
[task 2020-01-03T22:40:12.142Z] 22:40:12 INFO - Renderer: Intel Iris OpenGL Engine
[task 2020-01-03T22:40:12.142Z] 22:40:12 INFO - FBO Texture Target: TEXTURE_2D
[task 2020-01-03T22:40:12.142Z] 22:40:12 INFO - Buffered messages logged at 22:40:11
[task 2020-01-03T22:40:12.142Z] 22:40:12 INFO - Chrome script has loaded initial URI.
[task 2020-01-03T22:40:12.142Z] 22:40:12 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html" line: 0}]
[task 2020-01-03T22:40:12.142Z] 22:40:12 INFO - Chrome script created iframe
[task 2020-01-03T22:40:12.142Z] 22:40:12 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | win0 shouldn't be a dead wrapper before navigation - true == true -
[task 2020-01-03T22:40:12.143Z] 22:40:12 INFO - Console message: [JavaScript Warning: "The character encoding of a framed document was not declared. The document may appear different if viewed without the document framing it." {file: "http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html" line: 0}]
[task 2020-01-03T22:40:12.143Z] 22:40:12 INFO - Got an iframe load event!
[task 2020-01-03T22:40:12.143Z] 22:40:12 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | waiving xrays creates a new thing? - true == true -
[task 2020-01-03T22:40:12.143Z] 22:40:12 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | same to same-origin BrowsingContext match - {} == {} -
[task 2020-01-03T22:40:12.143Z] 22:40:12 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | same to same-origin WindowProxy match - [object Window] == [object Window] -
[task 2020-01-03T22:40:12.143Z] 22:40:12 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | win1 shouldn't be a dead wrapper before navigation - true == true -
[task 2020-01-03T22:40:12.143Z] 22:40:12 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | chromeWin1 shouldn't be a dead wrapper before navigation - true == true -
[task 2020-01-03T22:40:12.144Z] 22:40:12 INFO - Chrome script asking for load of http://example.com/browser/dom/tests/browser/file_postMessage_parent.html
[task 2020-01-03T22:40:12.144Z] 22:40:12 INFO - Chrome script done calling PostMessage
[task 2020-01-03T22:40:12.144Z] 22:40:12 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.com/browser/dom/tests/browser/file_postMessage_parent.html" line: 0}]
[task 2020-01-03T22:40:12.144Z] 22:40:12 INFO - Got an iframe load event!
[task 2020-01-03T22:40:12.144Z] 22:40:12 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | . Should get a remote outer window proxy when accessing old window proxy -
[task 2020-01-03T22:40:12.144Z] 22:40:12 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | . Should get a remote outer window proxy when accessing new window proxy -
[task 2020-01-03T22:40:12.145Z] 22:40:12 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | win1 shouldn't be a dead wrapper after navigation - true == true -
[task 2020-01-03T22:40:12.145Z] 22:40:12 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | chromeWin1 shouldn't be a dead wrapper after navigation - true == true -
[task 2020-01-03T22:40:12.145Z] 22:40:12 INFO - Buffered messages finished
[task 2020-01-03T22:40:12.145Z] 22:40:12 INFO - TEST-UNEXPECTED-FAIL | dom/tests/browser/browser_windowProxy_transplant.js | chromeWin1x should be a dead wrapper after navigation - false == true - got false, expected true (operator ==)
[task 2020-01-03T22:40:12.145Z] 22:40:12 INFO - Stack trace:
[task 2020-01-03T22:40:12.145Z] 22:40:12 INFO - ok@resource://specialpowers/SpecialPowersSandbox.jsm:86:21
[task 2020-01-03T22:40:12.145Z] 22:40:12 INFO - @chrome://mochitests/content/browser/dom/tests/browser/browser_windowProxy_transplant.js:156:11
[task 2020-01-03T22:40:12.145Z] 22:40:12 INFO - asyncexecute@resource://specialpowers/SpecialPowersSandbox.jsm:140:12
[task 2020-01-03T22:40:12.146Z] 22:40:12 INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1724:15
[task 2020-01-03T22:40:12.146Z] 22:40:12 INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:286:21
[task 2020-01-03T22:40:12.146Z] 22:40:12 INFO - JSWindowActor queryreceiveMessage@resource://specialpowers/SpecialPowersParent.jsm:1055:12
[task 2020-01-03T22:40:12.146Z] 22:40:12 INFO - JSWindowActor queryspawn@resource://specialpowers/SpecialPowersChild.jsm:1679:17
[task 2020-01-03T22:40:12.146Z] 22:40:12 INFO - @chrome://mochitests/content/browser/dom/tests/browser/browser_windowProxy_transplant.js:39:25
[task 2020-01-03T22:40:12.146Z] 22:40:12 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-01-03T22:40:12.146Z] 22:40:12 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-01-03T22:40:12.146Z] 22:40:12 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-01-03T22:40:12.146Z] 22:40:12 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67
[task 2020-01-03T22:40:12.146Z] 22:40:12 INFO - GECKO(3277) | {"action":"test_status","time":1578091211957,"thread":null,"pid":null,"source":"mochitest","test":"chrome://mochitests/content/browser/dom/tests/browser/browser_windowProxy_transplant.js","subtest":"content.win1x should be a dead wrapper after navigation - false == true","status":"FAIL","expected":"PASS","message":"got false, expected true (operator ==)\nStack trace:\nok@resource://specialpowers/SpecialPowersSandbox.jsm:86:21\n@chrome://mochitests/content/browser/dom/tests/browser/browser_windowProxy_transplant.js:160:11\nasyncexecute@resource://specialpowers/SpecialPowersSandbox.jsm:140:12\n_spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1724:15\nreceiveMessage@resource://specialpowers/SpecialPowersChild.jsm:286:21\nJSWindowActor queryreceiveMessage@resource://specialpowers/SpecialPowersParent.jsm:1055:12\nJSWindowActor queryspawn@resource://specialpowers/SpecialPowersChild.jsm:1679:17\n@chrome://mochitests/content/browser/dom/tests/browser/browser_windowProxy_transplant.js:39:25\nContent got event http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html {"event":"load","location":"http://example.com/browser/dom/tests/browser/file_postMessage_parent.html"}
[task 2020-01-03T22:40:12.146Z] 22:40:12 INFO - GECKO(3277) | AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34\nTester_execTest@chrome://mochikit/content/browser-test.js:1097:11\nnextTest/<@chrome://mochikit/content/browser-test.js:925:14\nSimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67\n","js_source":"TestRunner.js"}
[task 2020-01-03T22:40:12.147Z] 22:40:12 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | same to cross-origin navigation BrowsingContext match - {} == {} -

Hsin-Yi can you assign someone to take a look?

Flags: needinfo?(htsai)
Whiteboard: [stockwell unknown] → [stockwell needswork:owner]

Hi Nika, are you the right person to ask for help to look into this? Thanks.

Component: DOM: Core & HTML → DOM: Window and Location
Flags: needinfo?(htsai) → needinfo?(nika)

See also bug 1582568 - this test was disabled on linux and mac10.14 on that bug.

Assignee: nobody → continuation
Flags: needinfo?(nika)

Out of the 127 failures in this bug in the last 30 days, all but 6 of them are in non-Fission Mochitest. Bug 1582568 is similar. This test is trying to test a Fission feature, so maybe there's some issue with the way we try to flip enough prefs to simulate Fission. Still, it doesn't seem great that we do hit this with Fission enabled sometimes. Maybe we can at least focus the disabling a bit more to only apply when Fission is not enabled.

Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35f20a9d4af3
Updated disable for browser_windowProxy_transplant.js on macosx when Fission is not enabled. r=jmaher
QA Whiteboard: leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]

https://hg.mozilla.org/mozilla-central/rev/35f20a9d4af3

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
QA Whiteboard: leave-open
status-firefox72: --- → wontfix
status-firefox73: --- → affected
status-firefox-esr68: --- → unaffected
Status: RESOLVED → REOPENED
status-firefox74: fixed → ---
Keywords: leave-open
Resolution: FIXED → ---
Target Milestone: mozilla74 → ---

This failure is still occurring at moderately high intermittent basis on ubuntu1804 test image for linux1804-64/opt variant.

try push: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&tier=1%2C2%2C3&revision=eb7fca553fdee919f26cb9670b72dea812a89463&searchStr=linux1804-64%2Fopt%2Cbrowser-chrome

This test fails in 3/6 runs currently. I have retriggered more runs to get a better picture. I have also retriggered the same chunk on linux1804-64-shippable/opt to see if it fails there too.

The patch to disable this test for linux64 doesn't catch the case that I am seeing since the variant being tested here is opt whereas the skip-if condition specifies debug.

If the retrigger on both linux1804-64/opt and linux1804-64-shippable/opt shows moderate rate of intermittence, would it be acceptable if I put up a patch that disables this test for opt as well?

(In reply to Edwin Takahashi (:egao, :etakahashi) from comment #37)

If the retrigger on both linux1804-64/opt and linux1804-64-shippable/opt shows moderate rate of intermittence, would it be acceptable if I put up a patch that disables this test for opt as well?

It looks like almost all of the failures are still with Fission disabled (I only see a single failure with it enabled), and we don't care as much about it failing when Fission is disabled.

I think something along the lines of this would be good:
skip-if = !fission && (os == 'linux' || os == 'mac')

That'll disable it on non-Fission mochitests on Linux and OSX. It seems to be okay in non-Fission on Windows, for whatever reason.

I'll just write a patch to do that...

(In reply to Andrew McCreight [:mccr8] from comment #39)

I'll just write a patch to do that...

Thanks - the updated condition should catch all instances!

Depends on: 1608575

(In reply to Edwin Takahashi (:egao, :etakahashi) from comment #40)

Thanks - the updated condition should catch all instances!

Well, there is a single instance of it when Fission is enabled:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283363669&repo=mozilla-central&lineNumber=7500

But it should at least make this not be a nuisance on TreeHerder.

Depends on: 1609791
See Also: → 1582568

Bug 1582568 removed all of the special cases where this test was disabled, and the failure has not recurred.

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Depends on: 1582568
No longer depends on: 1609791
Resolution: --- → WORKSFORME
Whiteboard: [stockwell disabled]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: