1581969 - Don’t suggest Sync during Sync registration

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect)

Description

[Ryan Feeley [:rfeeley]]

Attachment: choose-what-to-sync.png

STEPS TO REPRODUCE

1. In a fresh profile, register for Sync and save the password

EXPECTED RESULTS

• I choose what to sync and complete registration

ACTUAL RESULTS

• While choosing what to sync, the CFR suggests I turn on Sync.

Comment 1

[Matthew N. [:MattN]]

I guess we can exclude this origin from the trigger I added in bug 1570372.

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1581969 - Don’t activate the newSavedLogin trigger on accounts.firefox.com. r=k88hudson

The user may be in the process of setting up Sync so prompting to setup login Sync from a CFR would be untimely.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d60ea8fbdc6
Don’t activate the newSavedLogin trigger on accounts.firefox.com. r=jaws

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Note, OK for beta uplift if it lands and sticks on m-c.

Comment 5

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ac10e9c0bc48

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/5d60ea8fbdc6

Comment 7

[Daniel Bodea [:danibodea]]

I have attempted to reproduce this issue in Nightly v71.0a1 from 2019-09-19, but it does not appear to reproduce with the basic steps from the description. There should be some way to know how to trigger that door hanger, specifically.
Matt, can you help? Do you know how to reproduce the issue, before attempting to verify it?

Comment 8

[Matthew N. [:MattN]]

Untested steps:

1. In a new profile chose to sign in to sync

• that should open https://accounts.firefox.com/?…

2. Submit a username and password that will allow the password saved doorhanger to appear

• You should be on the 'Choose what to Sync' page like attachment 9093437 [details]

3. Choose to save the login for accounts.firefox.com

Expected result:
No CFR

Actual result:
CFR: "Recommendation" icon appears in the address bar. If you click on it, it would suggest Sync.

I suggested a new profile since the CFR only appears 3 times ever. Also, I think it only appears once per day or something.

Comment 9

[Daniel Bodea [:danibodea]]

I managed to reproduce on Nightly v71.0a1 from 2019-09-16 and I have verified the fix on Nightly v71.0a1 from 2019-09-27 and Beta v70.0b9.
Verified on Windows 10.