1570372 - CFR Trigger: Offer Fx Sync when a password is saved

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Matthew N. [:MattN]]

Attachment: UX Spec 2019-07

After a user saves a login in Firefox, offer Firefox Sync.

Relationships KPI Deck Slide | UX Spec (scroll to the very bottom)

Targeting:

usesFirefoxSync == false

Trigger:
LoginStats:NewSavedPassword observer notification

Frequency:

{ lifetime: 3 },

Primary button action:

action: {
  type: "OPEN_PREFERENCES_PAGE",
  data: { category: "sync" },
},

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1570372 - Add a newSavedLogin CFR trigger for when a login is saved from a doorhanger. r=k88hudson

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1570372 - Add login sync "Never Lose a Password Again" CFR strings. r=k88hudson

Depends on D42074

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1570372 - Add a test for LoginStats:NewSavedPassword. r=sfoster

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5edeb9b98349
Add a newSavedLogin CFR trigger for when a login is saved from a doorhanger. r=k88hudson
https://hg.mozilla.org/integration/autoland/rev/d7fc40c8466c
Add login sync "Never Lose a Password Again" CFR strings. r=k88hudson,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/c383eea470b3
Add a test for LoginStats:NewSavedPassword. r=ntim

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/5edeb9b98349
https://hg.mozilla.org/mozilla-central/rev/d7fc40c8466c
https://hg.mozilla.org/mozilla-central/rev/c383eea470b3

Comment 6

[Matthew N. [:MattN]]

Only the trigger got implemented in this bug and it doesn't work yet because triggers assume that that hosts are involved but they aren't relevant for this one. That should hopefully be resolved after the other Fx70 CFR triggers are implemented.

The panel layout is also incorrect as CFR for features (not add-ons) currently assumes that it is promoting pinned tabs so it depends on bug 1571022 to fix that.

I filed bug 1574812 to track the remaining work that is currently blocked on other CFR work.