158197 - Horizontal rule (HR) doesn't align left or right

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[Jessica Blanco]

I found this problem on OS/2 and Windows NT. Couldn't find this one in bugzilla.

-Open up Composer.
-Insert Horizontal Line. Default H. Line is inserted - centered and 100% of window
-Open the H. Line properties and size the line to 50% of the window and align
the H.Line to the left or right.
-Notice the line stays centered in Composer. The size does change.

Expected result - The H. Line should get aligned right or left, not remain centered.

I also noticed that the H. Line and Anchor buttons are no longer on the
Composition Toolbar.

Comment 1

[Charles Manske]

The HTML looks just fine, e.g.:
<HR size="50%" align="right>
This seems to be a layout problem. Doesn't display correctly in Browser either.

Comment 2

[Charles Manske]

For an example, I meant:
<hr width="50%" size="2" align="right">
This would seem to be an HTML correctness issue.

Comment 3

[Charles Manske]

Attachment: Test file for align="left" and "right" for HR

Comment 4

[Charles Manske]

Is this also related to dbaron's fix to  bug 141054?

Comment 5

[Jerry]

use netscape7b1(20020614) to access the testcase, it works fine.
it is an regression happens after 0614.

Comment 6

[Charles Manske]

I tested 3 DTDs:
standard:     "-//W3C//DTD HTML 4.01//EN"
strict:       "http://www.w3.org/TR/html4/strict.dtd"
transitional: "-//W3C//DTD HTML 4.01 Transitional//EN"
This bug only occurs using the transitional DTD.

Comment 7

[Syd Logan]

--> david baron

Comment 8

[Mats Palmgren (inactive)]

*** Bug 160521 has been marked as a duplicate of this bug. ***

Comment 9

[Bill Weinman]

Please add "HR" to the description so that it shows up in searches for "HR
ALIGN". (I don't seem to have authority to do that.) "Horizontal Line" is
misnomerous. 

Also note that this is only broken in QUIRKS mode. See these examples: 

   http://bw.org/mozilla/hr-loose.html
   http://bw.org/mozilla/hr-quirks.html

--Bill

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: hacky fix

OK, here's a hacky fix.  It just looks for the wrapper frame if we don't have a
real frame, and gets the style data from that instead.	This hack is ugly, but
so is hr centering when we treat the HR as an inline...

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 93918 [details] [diff] [review]
hacky fix

r/sr=bzbarsky

Comment 12

[mjudge]

looks good for what it does.  I will put an r= on this.  dbaron, can you look at 
159207 and see what I am doing there to get around the selection and navigation 
of HRframes?

Comment 13

[mjudge]

Comment on attachment 93918 [details] [diff] [review]
hacky fix

marking r=

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 93918 [details] [diff] [review]
hacky fix

a=asa (on behalf of drivers) for checkin to 1.1

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked into trunk, 2002-08-06 05:59 PDT.

Comment 16

[chris hofmann]

a=chofmann for 1.0.1

Comment 17

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to MOZILLA_1_1_BRANCH, 2002-08-07 12:47 PDT.
Fix checked in to MOZILLA_1_0_BRANCH, 2002-08-08 14:28 PDT.

Comment 18

[Chris Petersen]

Verified on the Trunk builds : 0S X (2002-08-12-03) and Windows ME (2002-08-10-08).

Comment 19

[Chris Petersen]

Verified on 2002-08-12-08 1.0 (Windows ME)and 2002-08-12-05 1.0 (OS X).

Comment 20

[R.K.Aa.]

*** Bug 165252 has been marked as a duplicate of this bug. ***

Comment 21

[Bill Mason]

*** Bug 167284 has been marked as a duplicate of this bug. ***

Comment 22

[Bill Mason]

*** Bug 167448 has been marked as a duplicate of this bug. ***