Replace "sync disconnect" dialog and local data removal with simple confirmation dialog and no data removal
Categories
(Firefox :: Firefox Accounts, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | verified |
People
(Reporter: markh, Assigned: markh)
References
Details
Attachments
(1 file)
When disconnecting an FxA account, we currently show a confirmation dialog which also gives the user the ability to delete local browsing data as part of the disconnection. UX has concluded this was a mistake and many users were confused (thinking the data was going to remain locally but be deleted from our servers) so it has been decided to replace this with a simple confirmation dialog and no option for local data removal.
Further, the FxA and Sync decoupling work (bug 1570565) imposes a couple of additional requirements:
- It will become possible to disconnect from just sync but fxa still being signed in to the browser, or disconnecting from both sync and fxa.
- It will be possible to disconnect from the FxA toolbar as well as about:preferences#sync.
So the patch in this bug:
- Deletes the old dialog and functionality, replacing it with a simpler dialog which lives directly in browser/content rather than browser/content/preferences/...
- Adds a disconnect function to browser-sync.js - currently this is only called by the sync preferences page, but Vijay will end up calling it in bug 1575706 (which is why I moved it out of prefs)
- The functionality supports disconnecting just sync; while that's not used in this patch, it will be as part of the bug 1570565 effort
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
|
||
Comment 5•6 years ago
|
||
This is verified as fixed on Firefox 71.0a1 (2019-10-10) under Windows 10 64-bit and Mac OS X 10.16.4. "Disconnect Firefox?" confirmation dialog is successfully displayed together with "Firefox will disconnect from your account but won’t delete any of your browsing data on this device." message.
Description
•