1582106 - PiP window conflicts with Youtube miniplayer functionality

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P2)

Description

[Timea Cernea [:tbabos][inactive]]

Affected versions:
Nightly 71.0a1 (2019-09-17) (64-bit}
Beta 71.0b7

Affected platforms:
Windows 7/10

Steps to reproduce:

• Launch Nightly or Beta
• Go to youtube.com and play a video
• Toggle PiP window
• Click on the youtube miniplayer button

Expected result:
The youtube miniplayer should be displayed with the "This video is playing in PiP mode." screen while the video is played back in the PiP window

Actual Result:
The youtube miniplayer will play the video while the PiP window will freeze with a frame from the video. Recording: https://streamable.com/5dj4x

Notes:
Same happens if:

• enable youtube miniplayer
• enable PiP from the miniplayer
• click on "Open video page" button from the miniplayer
  PiP window freezes while the video is played back in the youtube normal window

Comment 1

[BugBot [:suhaib / :marco]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 2

[Mike Conley (:mconley) (:⚙️) (PTO Aug 24-28)]

Speaking with astevenson, we think the simplest solution is probably the best for now - we'll close the PiP player window iff the <video> being displayed is ever removed from the DOM. That will happen in bug 1583882.

Comment 3

[Cristian Craciun]

Build ID 20191022214314
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Verified as fixed on the latest Nightly build on Windows 10.