1582113 - test_autofill_from_bfcache.html fails with fission enabled

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P2)

Description

[Neil Deakin]

The test:

1. The pageHideEvent.persisted is false instead of true
2. Cannot navigate back in history near the end of the test

Comment 1

[Matthew N. [:MattN]]

(In reply to Neil Deakin from comment #0)

1. The pageHideEvent.persisted is false instead of true

Is there a DOM bug filed on this? It sounds like we'll need a DOM fix.

2. Cannot navigate back in history near the end of the test

That can easily be solved with SpecialPowers.spawnTask AFAICT so I think we're mostly blocked on the above.

Comment 2

[Neil Deakin]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

(In reply to Neil Deakin from comment #0)

1. The pageHideEvent.persisted is false instead of true

Is there a DOM bug filed on this? It sounds like we'll need a DOM fix.

I don't think I filed one.

Comment 3

[Matthew N. [:MattN]]

(In reply to Neil Deakin from comment #2)

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

(In reply to Neil Deakin from comment #0)

1. The pageHideEvent.persisted is false instead of true

Is there a DOM bug filed on this? It sounds like we'll need a DOM fix.

I don't think I filed one.

Hi Peter, is it intentional with Fission that a page doesn't get persisted in bfcache (or maybe just pageHideEvent.persisted lies?) when navigating cross-origin? Or will this get fixed by a dependency of bug 1467221? The test that relies on testing bfcache is pretty straightforward.

Comment 4

[Matthew N. [:MattN]]

Attachment: Bug 1582113 - Fix test_autofill_from_bfcache usage of history.back() for Fission. r=sfoster

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/655fc6e0528b
Fix test_autofill_from_bfcache usage of history.back() for Fission. r=sfoster

Comment 6

[Cosmin Sabou [:CosminS]]

Attachment: Bug 1582113 - Enable test_autofill_highlight.html on fission cause now it's fixed. r=MattN,sfoster

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2830baa75b96
Enable test_autofill_highlight.html on fission cause now it's fixed. r=sfoster

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/655fc6e0528b
https://hg.mozilla.org/mozilla-central/rev/2830baa75b96

Comment 9

[Peter Van der Beken [:peterv]]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #3)

Hi Peter, is it intentional with Fission that a page doesn't get persisted in bfcache (or maybe just pageHideEvent.persisted lies?) when navigating cross-origin? Or will this get fixed by a dependency of bug 1467221? The test that relies on testing bfcache is pretty straightforward.

At least nsDocShell::CanSavePresentation will need to be fixed for Fission (it uses GetInProcessSameTypeParent), but I don't know if that will fix this. But I'm a bit confused, the test is marked as completely fixed now, did the problem with persisted go away somehow?

Comment 10

[Neil Deakin]

The test isn't fixed. Only part 2 was fixed by patches in this bug which erroneously closed the bug. Also, the second part appears to have enabled a different test.

I filed a new bug 1592920 on the remaining and marked it as dependent on the CanSavePresentation change.

Comment 11

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732