1567175 - Make password manager fillin work in out of process iframes

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P2)

Comment 1

[Neil Deakin]

Some notes from work so far:

1. There is currently one synchronous message being used here: https://searchfox.org/mozilla-central/source/toolkit/components/passwordmgr/LoginRecipes.jsm#267
2. Some tests listen for messages from the login manager and expect to do things. With actors, there is no way to listen to the messages from sent to the actor.
3. There are some 'LoginStats:' messages that seem to be unused. Are they unused?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 3

[Neil Deakin]

Attachment: Bug 1567175, make LoginManagerContent and LoginManagerParent JS classes,r=MattN

Comment 4

[Neil Deakin]

Attachment: Bug 1567175, rename LoginManagerContent to LoginManagerChild, r=MattN

Depends on D47823

Comment 5

[Neil Deakin]

Attachment: Bug 1567175, support password manager in out of process iframes, r=MattN

Depends on D47824

Comment 6

[Neil Deakin]

Attachment: Bug 1567175, move password manager event listener attachment from content framescript to LoginManagerChild, and use the current window instead of the top level window for the argument passed to DOMInputPasswordAdded, r=MattN

Depends on D47825

Comment 7

[Neil Deakin]

Attachment: Bug 1567175, check opener that is used to determine which parent window to use for a password prompt in the parent process instead of in content, r=MattN

Depends on D47826

Comment 8

[Neil Deakin]

Attachment: Bug 1567175, enable some password manager tests in fission mode, r=MattN

Depends on D47828

Comment 10

[Neil Deakin]

Attachment: Bug 1567175, add a test that verifies that a cross process iframe with a password field saves the password on submit and page navigation, r=MattN

Depends on D47829

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa78dbe7934f
make LoginManagerContent and LoginManagerParent JS classes,r=MattN
https://hg.mozilla.org/integration/autoland/rev/89c5eec01e0b
rename LoginManagerContent to LoginManagerChild, r=MattN
https://hg.mozilla.org/integration/autoland/rev/33be184f8f63
support password manager in out of process iframes, r=MattN
https://hg.mozilla.org/integration/autoland/rev/df8f7ac2038f
move password manager event listener attachment from content framescript to LoginManagerChild, and use the current window instead of the top level window for the argument passed to DOMInputPasswordAdded, r=MattN
https://hg.mozilla.org/integration/autoland/rev/893a5851aa9d
check opener that is used to determine which parent window to use for a password prompt in the parent process instead of in content, r=MattN
https://hg.mozilla.org/integration/autoland/rev/bc2bffdac5e1
enable some password manager tests in fission mode, r=MattN
https://hg.mozilla.org/integration/autoland/rev/98d1f98161e6
add a test that verifies that a cross process iframe with a password field saves the password on submit and page navigation, r=MattN

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/aa78dbe7934f
https://hg.mozilla.org/mozilla-central/rev/89c5eec01e0b
https://hg.mozilla.org/mozilla-central/rev/33be184f8f63
https://hg.mozilla.org/mozilla-central/rev/df8f7ac2038f
https://hg.mozilla.org/mozilla-central/rev/893a5851aa9d
https://hg.mozilla.org/mozilla-central/rev/bc2bffdac5e1
https://hg.mozilla.org/mozilla-central/rev/98d1f98161e6