Closed Bug 1567175 Opened 10 months ago Closed 7 months ago

Make password manager fillin work in out of process iframes

Categories

(Toolkit :: Password Manager, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla72
Fission Milestone M4
Tracking Status
firefox72 --- fixed

People

(Reporter: enndeakin, Assigned: enndeakin)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(7 files)

No description provided.
Fission Milestone: --- → M4

Some notes from work so far:

  1. There is currently one synchronous message being used here: https://searchfox.org/mozilla-central/source/toolkit/components/passwordmgr/LoginRecipes.jsm#267
  2. Some tests listen for messages from the login manager and expect to do things. With actors, there is no way to listen to the messages from sent to the actor.
  3. There are some 'LoginStats:' messages that seem to be unused. Are they unused?

Bugbug thinks this bug is a task, but please change it back in case of error.

Type: defect → task
Depends on: 1570243
Depends on: 1573836
Depends on: 1573839
Blocks: 1582112
Blocks: 1582113
Blocks: 1582116
Blocks: 1582117
Blocks: 1582120
Depends on: 1582499
Depends on: 1584032
Attachment #9097796 - Attachment description: Bug 1567175, move password manager event listener attachment from content framescript to LoginManagerChild, r=MattN → Bug 1567175, move password manager event listener attachment from content framescript to LoginManagerChild, and use the current window instead of the top level window for the argument passed to DOMInputPasswordAdded, r=MattN
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aa78dbe7934f
make LoginManagerContent and LoginManagerParent JS classes,r=MattN
https://hg.mozilla.org/integration/autoland/rev/89c5eec01e0b
rename LoginManagerContent to LoginManagerChild, r=MattN
https://hg.mozilla.org/integration/autoland/rev/33be184f8f63
support password manager in out of process iframes, r=MattN
https://hg.mozilla.org/integration/autoland/rev/df8f7ac2038f
move password manager event listener attachment from content framescript to LoginManagerChild, and use the current window instead of the top level window for the argument passed to DOMInputPasswordAdded, r=MattN
https://hg.mozilla.org/integration/autoland/rev/893a5851aa9d
check opener that is used to determine which parent window to use for a password prompt in the parent process instead of in content, r=MattN
https://hg.mozilla.org/integration/autoland/rev/bc2bffdac5e1
enable some password manager tests in fission mode, r=MattN
https://hg.mozilla.org/integration/autoland/rev/98d1f98161e6
add a test that verifies that a cross process iframe with a password field saves the password on submit and page navigation, r=MattN
Blocks: 1577005
Regressions: 1608347
You need to log in before you can comment on or make changes to this bug.