Closed Bug 1582221 Opened 2 months ago Closed 2 months ago

Convert Android PGO build to use geckoview-androidTest.apk instead of Fennec

Categories

(GeckoView :: General, enhancement, P2)

Unspecified
All
enhancement

Tracking

(firefox70 wontfix, firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox70 --- wontfix
firefox71 --- fixed

People

(Reporter: snorp, Assigned: mshal)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

This uses Fennec for generating the profile now, but we need to convert it over to GeckoViewExample.

:mshal, would you be willing to look at this?

Flags: needinfo?(mshal)
Rank: 11
Priority: -- → P2

(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) (he/him) from comment #0)

This uses Fennec for generating the profile now, but we need to convert it over to GeckoViewExample.

Is there a difference between using geckoview_example.apk and geckoview-androidTest.apk? With geckoview_example it fails with:

18:13:13 FATAL - ADBError: Error possibly due to runner or device args: launch_activity org.mozilla.geckoview_example/org.mozilla.geckoview_example.TestRunnerActivity failed

Though maybe we just need to change the activity name somewhere.

While geckoview-androidTest.apk seems to work out of the box with the current PGO script: https://treeherder.mozilla.org/#/jobs?repo=try&revision=476673a3656e83b9bbe87015eda49ffd08420093 - any reason we can't just use that?

Flags: needinfo?(mshal) → needinfo?(snorp)

Yeah, that's due to using the wrong activity name. If it works with the test app I think that's fine.

Flags: needinfo?(snorp)
Assignee: nobody → mshal
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c87cd65ab8a
Use geckoview-androidTest instead of Fennec for Android PGO; r=snorp
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

firefox70=wontfix because (AFAIK) we don't need to uplift this PGO change to 70 Beta. We're still using 70 Beta's Fennec builds to generate the PGO profile, so we don't need to change 70 Beta to use geckoview-androidTest.apk.

We should monitor Android perf benchmark for unexpected changes over the next couple days, in case there is a problem with the PGO profile generated using geckoview-androidTest.apk.

Summary: Convert PGO build to use GeckoViewExample → Convert Android PGO build to use geckoview-androidTest.apk instead of Fennec
You need to log in before you can comment on or make changes to this bug.