1582221 - Convert Android PGO build to use geckoview-androidTest.apk instead of Fennec

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P2)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

This uses Fennec for generating the profile now, but we need to convert it over to GeckoViewExample.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

:mshal, would you be willing to look at this?

Comment 2

[Michael Shal [:mshal]]

(In reply to James Willcox (:snorp) ([e-mail]) (he/him) from comment #0)

This uses Fennec for generating the profile now, but we need to convert it over to GeckoViewExample.

Is there a difference between using geckoview_example.apk and geckoview-androidTest.apk? With geckoview_example it fails with:

18:13:13 FATAL - ADBError: Error possibly due to runner or device args: launch_activity org.mozilla.geckoview_example/org.mozilla.geckoview_example.TestRunnerActivity failed

Though maybe we just need to change the activity name somewhere.

While geckoview-androidTest.apk seems to work out of the box with the current PGO script: https://treeherder.mozilla.org/#/jobs?repo=try&revision=476673a3656e83b9bbe87015eda49ffd08420093 - any reason we can't just use that?

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Yeah, that's due to using the wrong activity name. If it works with the test app I think that's fine.

Comment 4

[Michael Shal [:mshal]]

Attachment: Bug 1582221 - Use geckoview-androidTest instead of Fennec for Android PGO; r?snorp

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c87cd65ab8a
Use geckoview-androidTest instead of Fennec for Android PGO; r=snorp

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3c87cd65ab8a

Comment 7

[Chris Peterson [:cpeterson]]

firefox70=wontfix because (AFAIK) we don't need to uplift this PGO change to 70 Beta. We're still using 70 Beta's Fennec builds to generate the PGO profile, so we don't need to change 70 Beta to use geckoview-androidTest.apk.

We should monitor Android perf benchmark for unexpected changes over the next couple days, in case there is a problem with the PGO profile generated using geckoview-androidTest.apk.