[meta] Remove Fennec code
Categories
(GeckoView :: General, enhancement, P3)
Tracking
(firefox-esr68 wontfix)
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | wontfix |
People
(Reporter: snorp, Unassigned)
References
(Depends on 13 open bugs)
Details
(Keywords: meta)
Attachments
(4 obsolete files)
Out with the old, in with the new.
|
Reporter | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
||
Comment 1•5 years ago
|
||
One thing to note is that we'll want to keep the l10n config files for fennec around as long as we ship that from ESR. The reason is that the cross-channel code can merge l10n files across branches, but not the config files, so we're taking those from m-c.
|
|
Reporter | |
Comment 2•5 years ago
|
||
(In reply to Axel Hecht [:Pike] from comment #1)
One thing to note is that we'll want to keep the l10n config files for fennec around as long as we ship that from ESR. The reason is that the cross-channel code can merge l10n files across branches, but not the config files, so we're taking those from m-c.
OK that's good info, thanks. I don't think I actually know which files you're referring to, though. Could you share a link?
|
|
||
Comment 3•5 years ago
|
||
Sure,
mobile/locales/l10n.ini
mobile/locales/filter.py
mobile/android/locales/l10n.ini
mobile/android/locales/maemo-locales
mobile/android/locales/all-locales
mobile/android/locales/filter.py
mobile/android/locales/l10n.toml
|
|
||
Comment 4•5 years ago
|
||
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) (he/him) from comment #2)
(In reply to Axel Hecht [:Pike] from comment #1)
One thing to note is that we'll want to keep the l10n config files for fennec around as long as we ship that from ESR. The reason is that the cross-channel code can merge l10n files across branches, but not the config files, so we're taking those from m-c.
OK that's good info, thanks. I don't think I actually know which files you're referring to, though. Could you share a link?
Just FYI, I've taken @snorp's advice and just torn Fennec out entirely. My current patches (see https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b337cdb7e0bd2fba187bbbb99525a6339660086) don't touch l10n in any way, for this and related reasons. Tearing out Fennec omnijar pieces, and simplifying the l10n process, will be follow-up.
|
||
Updated•5 years ago
|
|
||
Comment 5•5 years ago
|
||
|
|
||
Comment 6•5 years ago
|
||
Some of this may be able to be cleaned up further.
|
|
||
Comment 7•5 years ago
|
||
Didn't want to remove all the WebAuthn code so I left it there in case it's
useful.
|
|
||
Comment 8•5 years ago
|
||
While we're at it...
|
||
Comment 9•5 years ago
|
||
Comment on attachment 9101824 [details]
Bug 1582218 - Remove Fennec history implementation.
Revision D49586 was moved to bug 1589327. Setting attachment 9101824 [details] to obsolete.
|
|
||
Comment 10•5 years ago
|
||
Whoops, that was meant to be in bug 1589327.
|
|
||
Comment 11•5 years ago
|
||
Comment on attachment 9101825 [details]
Bug 1582218 - Remove some other various fennec-dependent code.
Revision D49587 was moved to bug 1589327. Setting attachment 9101825 [details] to obsolete.
|
|
||
Comment 12•5 years ago
|
||
Comment on attachment 9101826 [details]
Bug 1582218 - Remove more dead code conditional on jni::IsFennec() or similar.
Revision D49588 was moved to bug 1589327. Setting attachment 9101826 [details] to obsolete.
|
|
||
Comment 13•5 years ago
|
||
Comment on attachment 9101827 [details]
Bug 1582218 - Remove GeckoViewNavigationChild.
Revision D49589 was moved to bug 1589327. Setting attachment 9101827 [details] to obsolete.
|
|
||
Updated•5 years ago
|
|
||
Comment 14•5 years ago
|
||
Sorry Chris but I updated the alias to make it more explicit ;)
|
||
Updated•5 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•3 years ago
|
|
|
||
Updated•2 years ago
|
Description
•