Open Bug 1582218 (remove-fennec) Opened 3 months ago Updated Last month

[meta] Remove Fennec code

Categories

(Firefox for Android :: General, enhancement, P2)

Unspecified
Android
enhancement

Tracking

()

Tracking Status
firefox-esr68 --- wontfix

People

(Reporter: snorp, Unassigned)

References

(Depends on 11 open bugs)

Details

(Keywords: meta)

Attachments

(4 obsolete files)

Out with the old, in with the new.

Alias: defennec
Depends on: 1577037
Depends on: 1577863
Depends on: 1583370

One thing to note is that we'll want to keep the l10n config files for fennec around as long as we ship that from ESR. The reason is that the cross-channel code can merge l10n files across branches, but not the config files, so we're taking those from m-c.

(In reply to Axel Hecht [:Pike] from comment #1)

One thing to note is that we'll want to keep the l10n config files for fennec around as long as we ship that from ESR. The reason is that the cross-channel code can merge l10n files across branches, but not the config files, so we're taking those from m-c.

OK that's good info, thanks. I don't think I actually know which files you're referring to, though. Could you share a link?

Flags: needinfo?(l10n)

Sure,

mobile/locales/l10n.ini
mobile/locales/filter.py
mobile/android/locales/l10n.ini
mobile/android/locales/maemo-locales
mobile/android/locales/all-locales
mobile/android/locales/filter.py
mobile/android/locales/l10n.toml
Flags: needinfo?(l10n)

(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) (he/him) from comment #2)

(In reply to Axel Hecht [:Pike] from comment #1)

One thing to note is that we'll want to keep the l10n config files for fennec around as long as we ship that from ESR. The reason is that the cross-channel code can merge l10n files across branches, but not the config files, so we're taking those from m-c.

OK that's good info, thanks. I don't think I actually know which files you're referring to, though. Could you share a link?

Just FYI, I've taken @snorp's advice and just torn Fennec out entirely. My current patches (see https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b337cdb7e0bd2fba187bbbb99525a6339660086) don't touch l10n in any way, for this and related reasons. Tearing out Fennec omnijar pieces, and simplifying the l10n process, will be follow-up.

Blocks: 1565634
See Also: → 1583313
Priority: -- → P2
Depends on: 1538348
Depends on: 1465387
Depends on: 1316220
Depends on: 1510785
Depends on: 1585667
Depends on: 1584400
No longer depends on: 1586037
Depends on: 1589327

Some of this may be able to be cleaned up further.

Didn't want to remove all the WebAuthn code so I left it there in case it's
useful.

While we're at it...

Comment on attachment 9101824 [details]
Bug 1582218 - Remove Fennec history implementation.

Revision D49586 was moved to bug 1589327. Setting attachment 9101824 [details] to obsolete.

Attachment #9101824 - Attachment is obsolete: true

Whoops, that was meant to be in bug 1589327.

Comment on attachment 9101825 [details]
Bug 1582218 - Remove some other various fennec-dependent code.

Revision D49587 was moved to bug 1589327. Setting attachment 9101825 [details] to obsolete.

Attachment #9101825 - Attachment is obsolete: true

Comment on attachment 9101826 [details]
Bug 1582218 - Remove more dead code conditional on jni::IsFennec() or similar.

Revision D49588 was moved to bug 1589327. Setting attachment 9101826 [details] to obsolete.

Attachment #9101826 - Attachment is obsolete: true

Comment on attachment 9101827 [details]
Bug 1582218 - Remove GeckoViewNavigationChild.

Revision D49589 was moved to bug 1589327. Setting attachment 9101827 [details] to obsolete.

Attachment #9101827 - Attachment is obsolete: true
Depends on: 1590172
Alias: defennec → defennecstration
OS: Unspecified → Android

Sorry Chris but I updated the alias to make it more explicit ;)

Alias: defennecstration → remove-fennec
Depends on: 1593395
You need to log in before you can comment on or make changes to this bug.