Closed Bug 1582311 Opened 5 years ago Closed 1 year ago

99,353 instances of "nsAppShell::Exit() called redundantly" emitted from widget/cocoa/nsAppShell.mm during macosx1015-64-qr debug testing

Categories

(Core :: Widget: Cocoa, defect, P3)

Product:
Core
Component:
Widget: Cocoa
Platform:
All
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: erahm, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1582311 - Remove warning about nsAppShell::Exit() being called redundantly.
48 bytes, text/x-phabricator-request
Details | Review

30477 WARNING: nsAppShell::Exit() called redundantly: file widget/cocoa/nsAppShell.mm, line 725

This warning [1] shows up in the following test suites:

  2109 - test-macosx1014-64/debug-web-platform-tests-e10s-2 wpt2
  1924 - test-macosx1014-64/debug-web-platform-tests-e10s-13 wpt13
  1887 - test-macosx1014-64/debug-web-platform-tests-e10s-16 wpt16
  1782 - test-macosx1014-64/debug-web-platform-tests-e10s-7 wpt7
  1560 - test-macosx1014-64/debug-web-platform-tests-e10s-10 wpt10
  1374 - test-macosx1014-64/debug-web-platform-tests-e10s-15 wpt15
  1336 - test-macosx1014-64/debug-web-platform-tests-e10s-6 wpt6
  1330 - test-macosx1014-64/debug-web-platform-tests-e10s-11 wpt11
  1263 - test-macosx1014-64/debug-web-platform-tests-e10s-4 wpt4
  1231 - test-macosx1014-64/debug-web-platform-tests-e10s-1 wpt1
  1171 - test-macosx1014-64/debug-web-platform-tests-e10s-8 wpt8
  1166 - test-macosx1014-64/debug-web-platform-tests-e10s-5 wpt5
  1152 - test-macosx1014-64/debug-web-platform-tests-e10s-9 wpt9
  1133 - test-macosx1014-64/debug-web-platform-tests-e10s-3 wpt3
  1040 - test-macosx1014-64/debug-web-platform-tests-e10s-14 wpt14
   850 - test-macosx1014-64/debug-web-platform-tests-wdspec-e10s-1 Wd1
   754 - test-macosx1014-64/debug-web-platform-tests-e10s-12 wpt12
   496 - test-macosx1014-64/debug-web-platform-tests-wdspec-e10s-2 Wd2
   460 - test-macosx1014-64/debug-reftest-e10s-4 R4
   458 - test-macosx1014-64/debug-reftest-e10s-3 R3
   449 - test-macosx1014-64/debug-reftest-e10s-2 R2
   427 - test-macosx1014-64/debug-reftest-e10s-1 R1
   286 - test-macosx1014-64/debug-web-platform-tests-reftests-e10s-1 Wr1
   258 - test-macosx1014-64/debug-web-platform-tests-reftests-e10s-6 Wr6
   253 - test-macosx1014-64/debug-web-platform-tests-reftests-e10s-5 Wr5
   243 - test-macosx1014-64/debug-web-platform-tests-reftests-e10s-2 Wr2
   240 - test-macosx1014-64/debug-marionette-e10s Mn
   231 - test-macosx1014-64/debug-mochitest-browser-chrome-e10s-4 bc4
   231 - test-macosx1014-64/debug-web-platform-tests-reftests-e10s-4 Wr4
   225 - test-macosx1014-64/debug-web-platform-tests-reftests-e10s-3 Wr3
   186 - test-macosx1014-64/debug-mochitest-browser-chrome-e10s-8 bc8
   186 - test-macosx1014-64/debug-mochitest-browser-chrome-e10s-3 bc3
   182 - test-macosx1014-64/debug-mochitest-e10s-5 5
   177 - test-macosx1014-64/debug-mochitest-browser-chrome-e10s-10 bc10
   177 - test-macosx1014-64/debug-mochitest-browser-chrome-e10s-7 bc7
   177 - test-macosx1014-64/debug-mochitest-browser-chrome-e10s-9 bc9
   175 - test-macosx1014-64/debug-mochitest-browser-chrome-e10s-2 bc2
   167 - test-macosx1014-64/debug-mochitest-browser-chrome-e10s-5 bc5
   165 - test-macosx1014-64/debug-mochitest-browser-chrome-e10s-6 bc6
   141 - test-macosx1014-64/debug-mochitest-e10s-3 3
   130 - test-macosx1014-64/debug-mochitest-browser-chrome-e10s-1 bc1
   126 - test-macosx1014-64/debug-mochitest-e10s-2 2
   121 - test-macosx1014-64/debug-mochitest-e10s-1 1
   121 - test-macosx1014-64/debug-mochitest-e10s-4 4
    99 - test-macosx1014-64/debug-mochitest-chrome-1proc-1 c1
    86 - test-macosx1014-64/debug-firefox-ui-functional-local-e10s en-US
    77 - test-macosx1014-64/debug-mochitest-devtools-chrome-e10s-3 dt3
    67 - test-macosx1014-64/debug-mochitest-chrome-1proc-2 c2
    65 - test-macosx1014-64/debug-mochitest-devtools-chrome-e10s-2 dt2
    64 - test-macosx1014-64/debug-mochitest-devtools-chrome-e10s-6 dt6
    64 - test-macosx1014-64/debug-mochitest-devtools-chrome-e10s-5 dt5
    56 - test-macosx1014-64/debug-mochitest-devtools-chrome-e10s-1 dt1
    41 - test-macosx1014-64/debug-mochitest-media-spi-e10s-2 mda2
    38 - test-macosx1014-64/debug-mochitest-media-spi-e10s-1 mda1
    37 - test-macosx1014-64/debug-mochitest-devtools-chrome-e10s-4 dt4
    37 - test-macosx1014-64/debug-telemetry-tests-client-e10s c
    33 - test-macosx1014-64/debug-mochitest-media-e10s-2 mda2
    31 - test-macosx1014-64/debug-mochitest-media-e10s-1 mda1
    30 - test-macosx1014-64/debug-mochitest-devtools-chrome-e10s-7 dt7
    22 - test-macosx1014-64/debug-mochitest-gpu-e10s gpu
    20 - test-macosx1014-64/debug-mochitest-webgl1-core-e10s gl1c
    10 - test-macosx1014-64/debug-mochitest-remote-e10s remote
    10 - test-macosx1014-64/debug-mochitest-browser-chrome-e10s-12 bc12
    10 - test-macosx1014-64/debug-mochitest-devtools-chrome-e10s-8 dt8
    10 - test-macosx1014-64/debug-mochitest-browser-chrome-e10s-11 bc11
     6 - test-macosx1014-64/debug-crashtest-e10s C
     5 - test-macosx1014-64/debug-firefox-ui-functional-remote-e10s en-US
     4 - test-macosx1014-64/debug-mochitest-webgl1-ext-e10s gl1e
     4 - test-macosx1014-64/debug-mochitest-webgl2-core-e10s gl2c
     1 - test-macosx1014-64/debug-mochitest-a11y-1proc a11y

It shows up in 18200 tests. A few of the most prevalent:

  2823 - [e10s] Shutdown
   108 - [e10s] /webdriver/tests/new_session/create_alwaysMatch.py
   108 - [e10s] /webdriver/tests/new_session/create_firstMatch.py
   103 -        Shutdown
    30 -        browser/components/shell/test/test_headless_screenshot.html
    30 - [e10s] /webdriver/tests/new_window/user_prompts.py
    26 - [e10s] browser/base/content/test/tabs/browser_privilegedmozilla_process_pref.js
    24 - [e10s] /webdriver/tests/is_element_selected/user_prompts.py
    24 - [e10s] /webdriver/tests/get_window_handle/user_prompts.py
    24 - [e10s] /webdriver/tests/find_element/user_prompts.py

[1] https://hg.mozilla.org/mozilla-central/annotate/a3a081ae714f1123bdc23c9d9ef53dfaa783a8de/widget/cocoa/nsAppShell.mm#l725

OS: All → macOS
Priority: -- → P3
Severity: normal → S4

This is currently the third most common warning across OSX test runs.

The current warning is:

WARNING: nsAppShell::Exit() called redundantly: file widget/cocoa/nsAppShell.mm:861

Summary: 30,500 instances of "nsAppShell::Exit() called redundantly" emitted from widget/cocoa/nsAppShell.mm during macosx1014-64 debug testing → 99,353 instances of "nsAppShell::Exit() called redundantly" emitted from widget/cocoa/nsAppShell.mm during macosx1015-64-qr debug testing

This is now the most common warning across OSX test runs. It occurs around 99,000 times, while the next most common only occurs 52,000 times.

Assignee: nobody → continuation

This warning was added in 2007, so I don't think it is anybody's priority to
fix. It is currently the most common warning on OSX test runs, occurring
almost twice as much as the next most common warning, so let's just remove it.

See Also: → 402497
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f71c2cb8e0a Remove warning about nsAppShell::Exit() being called redundantly. r=spohl DONTBUILD

https://hg.mozilla.org/mozilla-central/rev/7f71c2cb8e0a

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: