402497 - "WARNING: nsAppShell::Exit() called redundantly" on shutdown

Status: RESOLVED INCOMPLETE

(Core :: Widget, defect)

Description

[Jesse Ruderman]

1. Launch Firefox (Mac trunk debug) (from the command line).
2. Cmd+Q.

Result: during shutdown, the following warning appears:

WARNING: nsAppShell::Exit() called redundantly: file /Users/jruderman/trunk/mozilla/widget/src/cocoa/nsAppShell.mm, line 560

(This used to be an assertion, but it was downgraded to a warning in bug 396833.)

Comment 1

[Steven Michaud [:smichaud] (Retired)]

This problem is very old, and (probably) cross-platform.  (At some
point I'll use the tryserver to do a Linux build to find out for
sure.)

In any case it shouldn't block bug 395397, because that bug didn't
cause this problem (it just started complaining about it).

Comment 2

[Steven Michaud [:smichaud] (Retired)]

Attachment: Traces of two consecutive calls to nsAppShell::Exit in Minefield (on OS X)

Here are traces of both of the calls to nsAppShell::Exit() that are
made on the trunk (in Minefield) on OS X.

A bit to my surprise, I didn't find this problem on the 1.8 branch (in
Firefox).  So it seems to be trunk-only.

I'll try to do a trunk build (with debug symbols) on Linux, and see
what I get.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Attachment: Traces of two consecutive calls to nsBaseAppShell::Exit in Minefield (on Linux)

Here are traces of what appear to be exactly the same two calls, this
time in Minefield (a debug build) on Linux.  So I was right that this
is a cross-platform bug.

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

A clean Mac trunk Thunderbird debug build outputs the following on shutdown:

WARNING: nsAppShell::Exit() called redundantly: file /Users/skywalker/Desktop/Mozilla/cvs/mozilla/widget/src/cocoa/nsAppShell.mm, line 604

Comment 5

[Ryo Kawaguchi]

I observe the same phenomenon on a clean trunk Firefox build on OS X.

WARNING: nsAppShell::Exit() called redundantly: file /Users/Sora/mozilla/src.clean/widget/src/cocoa/nsAppShell.mm, line 782

followed by

nsStringStats
 => mAllocCount:          19125
 => mReallocCount:         2894
 => mFreeCount:           12447  --  LEAKED 6678 !!!
 => mShareCount:          12249
 => mAdoptCount:           1236
 => mAdoptFreeCount:       1233  --  LEAKED 3 !!!

This happens only when quitting Firefox with Cmd+Q from Cmd+Tab while Firefox does not have a focus and does not happen when quitting Firefox with Cmd+Q when Firefox has a focus.

Comment 6

[Daniel Holbert [:dholbert]]

(In reply to comment #5)
> This happens only when quitting Firefox with Cmd+Q from Cmd+Tab while Firefox
> does not have a focus and does not happen when quitting Firefox with Cmd+Q when
> Firefox has a focus.

So, it sounds like the Steps To Reproduce have changed here, right?

(Jesse & Gary, can you still reproduce this bug using your original steps as in Comment 0 & Comment 4?)

Comment 7

[Jesse Ruderman]

Yes, I still see this warning with the steps in comment 0.  So if Ryo only hits this with more complicated steps, he might be hitting a different bug.  Or something.

Comment 8

[Andrew McCreight [:mccr8]]

No need to leave an ancient warning spam bug open, in my opinion.