1582353 - Make GPU/RDD decoder IPC methods use MozPromise

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Jean-Yves Avenard [:jya]]

Right now RDD/GPU decoder methods use callbacks with a shim that convert those calls to MozPromise.

Should be moving to native MozPromise support for ease of use and that ability to return more than one decoded sample at a time.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1582353 - P1. Add MediaResult serializer. r?mjf

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1582353 - P2. Remove unused variable. r?mattwoodrow

The MediaResult object isn't used; no need to set a crash timestamp on it.

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1582353 - P3. Promisify RDD/GPU remote decoder. r=mattwoodrow!,mjf!

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1582353 - P4. Remove the need to explicitly inform child/parent that a Shmem is no longer in use. r=mjf!

We can deduct it from the workflow itself.

Also fix potential Shmem leak.

Comment 6

[Phabricator Automation]

Comment on attachment 9095524 [details]
Bug 1582353 - P4. Remove the need to explicitly inform child/parent that a Shmem is no longer in use. r=mjf!

Revision D47261 was moved to bug 1584721. Setting attachment 9095524 [details] to obsolete.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1fb5cfcff24
P1. Add MediaResult serializer. r=mjf
https://hg.mozilla.org/integration/autoland/rev/385f51415b32
P2. Remove unused variable. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/1af599d73633
P3. Promisify RDD/GPU remote decoder. r=mattwoodrow,mjf

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e1fb5cfcff24
https://hg.mozilla.org/mozilla-central/rev/385f51415b32
https://hg.mozilla.org/mozilla-central/rev/1af599d73633